| Subject: | ChallengeResponseAuthentication should probably be a str_yesno rather than a set_str |
Net-SSH-Perl-1.28
Perl 5.8.6
Darwin 8.2.0 Darwin Kernel Version 8.2.0: Fri Jun 24 17:46:54 PDT 2005; root:xnu-792.2.4.obj~3/RELEASE_PPC Power Macintosh powerpc
Testing a simple login script against a server that allowed ChallengeResponse Authentication revealed that no matter what the ChallengeResponseAuthentication option was set to, would always try ChallengeResponseAuthentication. Reading the code suggested to
me that it should probably be used with _str_yesno rather than _set_str.
Just my reading of the code, this interpretation may be way off the mark.
Changing to use _str_yesno produced expected behaviour with option
setting.
Trivial patch attached.
Cheers,
Mark
--- Net/SSH/Perl/Config.pm.orig 2005-09-11 21:42:44.000000000 +0100
+++ Net/SSH/Perl/Config.pm 2005-09-11 21:43:00.000000000 +0100
@@ -11,7 +11,7 @@
BindAddress => [ \&_set_str, 'bind_address' ],
Host => [ \&_host ],
BatchMode => [ \&_batch_mode ],
- ChallengeResponseAuthentication => [ \&_set_str, 'auth_ch_res' ],
+ ChallengeResponseAuthentication => [ \&_set_yesno, 'auth_ch_res' ],
Cipher => [ \&_cipher ],
Ciphers => [ \&_set_str, 'ciphers' ],
Compression => [ \&_set_yesno, 'compression' ],