| Subject: | Formatting of code in Pg.pm hinders rpm auto-provides detection |
The coding style used at the top of Pg.pm changed some time after version 1.41 from:
{
package DBD::Pg;
to:
{ package DBD::Pg;
Whilst this is just a cosmetic issue as far as coding style is concerned, the rudimentary perl parser used by RPM fails to grok the new style and hence RPM packages of DBD::Pg 1.43 don't automatically "provide" the perl(DBD::Pg) module dependency, which is a bit unfortunate when this is used to track module interdependencies (one of the key features of RPM).
Please consider applying the attached patch for future versions to revert the coding style back to an RPM-parsable state. Obviously it would be better to fix RPM to parse the code properly but that wouldn't help users of older distributions that didn't include a fixed version of RPM.
I've also submitted this patch to Red Hat's bugzilla since version 1.43 of DBD::Pg is currently in the development tree for Fedora Core 5.
http://bugzilla.redhat.com/167797
--- DBD-Pg-1.43/Pg.pm 2005-09-08 11:50:20.000000000 +0100
+++ DBD-Pg-1.43/Pg.pm 2005-09-08 11:50:39.805319204 +0100
@@ -14,7 +14,8 @@
-{ package DBD::Pg;
+{
+ package DBD::Pg;
our $VERSION = '1.43';