Bug #14493 for CGI-Uploader: Specify the tempfile directory in the instance

Wed Sep 07 09:08:32 2005 Guest - Ticket created

Subject:

Specify the tempfile directory in the instance

Hello Mark, It would be nice if there was a configuration so that I could declare where I want my tempfiles to be created. Otherwise when I use your module I have to give the www user write permissions on the directory my script is in. ~ Steven

Wed Sep 07 09:46:54 2005 mark [...] summersault.com - Correspondence added

Date:	Wed, 7 Sep 2005 08:46:22 -0500
From:	Mark Stosberg <mark [...] summersault.com>
To:	Guest via RT <bug-CGI-Uploader [...] rt.cpan.org>
Subject:	Re: [cpan #14493] Specify the tempfile directory in the instance
RT-Send-Cc:

On Wed, Sep 07, 2005 at 09:08:33AM -0400, Guest via RT wrote: Show quoted text

> > It would be nice if there was a configuration so that I could declare > where I want my tempfiles to be created. Otherwise when I use your > module I have to give the www user write permissions on the directory > my script is in.

Seems reasonable. Patches, tests welcome. Mark

Mon Jul 31 12:04:49 2006 MARKSTOS [...] cpan.org - Requestor bignose@gmail.com added

Mon Jul 31 12:05:08 2006 MARKSTOS [...] cpan.org - Status changed from 'new' to 'open'

Mon Jul 31 12:05:29 2006 MARKSTOS [...] cpan.org - Severity Wishlist changed to Normal

Mon Jul 31 12:05:30 2006 MARKSTOS [...] cpan.org - Broken in 2.11 added

Mon Jul 31 12:05:35 2006 MARKSTOS [...] cpan.org - Taken

Mon Jul 31 12:08:34 2006 MARKSTOS [...] cpan.org - Correspondence added

Show quoted text

> Hi, > > There a change to Uploader.pm I made a while back but It never made it > into the distribution > > Change line 630 of Uploader.pm from this > > my ($tmp_fh, $tmp_filename) = tempfile('CGIuploaderXXXXX', UNLINK => 1); > > To this > > my ($tmp_fh, $tmp_filename) = tempfile('CGIuploaderXXXXX', UNLINK => > 1, DIR => $self->{'temp_dir'}); > > And add temp_dir => { type => SCALAR }, to the validate parmaters on

line 239 Show quoted text

> > I can submit a more formal patch if need be, but I thought this one > was pretty simple. > > Jeff.

Jeff, Please do prepare a patch, including updating 'Changes', docs, and hopefully, a test. Also, use the RT bug tracker for future bugs and wishes, which makes it easier to me to stay organized about them. Mark

Mon Jul 31 12:08:35 2006 MARKSTOS [...] cpan.org - Status changed from 'open' to 'stalled'

Mon Jul 31 16:18:21 2006 bignose [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #14493] Specify the tempfile directory in the instance
Date:	Mon, 31 Jul 2006 16:18:06 -0400
To:	bug-CGI-Uploader [...] rt.cpan.org
From:	"Jeff MacDonald" <bignose [...] gmail.com>

Please see attached patch [i hope i did it right] used diff -u tomakethe files. 3 files included Uploader.pm Imagemagick.pm and Changes file. These only include the temp_file fix. If you'd prefer darcs, I can do that. jeff. On 7/31/06, via RT <bug-CGI-Uploader@rt.cpan.org> wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=14493 > >

> > Hi, > > > > There a change to Uploader.pm I made a while back but It never made it > > into the distribution > > > > Change line 630 of Uploader.pm from this > > > > my ($tmp_fh, $tmp_filename) = tempfile('CGIuploaderXXXXX', UNLINK => 1); > > > > To this > > > > my ($tmp_fh, $tmp_filename) = tempfile('CGIuploaderXXXXX', UNLINK => > > 1, DIR => $self->{'temp_dir'}); > > > > And add temp_dir => { type => SCALAR }, to the validate parmaters on

> line 239

> > > > I can submit a more formal patch if need be, but I thought this one > > was pretty simple. > > > > Jeff.

> > Jeff, > > Please do prepare a patch, including updating 'Changes', docs, and > hopefully, a test. > > Also, use the RT bug tracker for future bugs and wishes, which makes it > easier > to me to stay organized about them. > > Mark > >

-- Unless otherwise indicated, anything I write is either garnered from experience or pulled out of my ass, depending on situational needs.. Jeff MacDonald

Download uploader.patch.tgz
application/x-gzip 1.3k

Message body not shown because it is not plain text.

Mon Jul 31 16:18:23 2006 The RT System itself - Status changed from 'stalled' to 'open'

Mon Apr 09 22:39:12 2007 MARKSTOS [...] cpan.org - Correspondence added

This was released in 2.12.

Mon Apr 09 22:39:13 2007 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'