Bug #14299 for SVN-Notify: Style improvement in commit mails

Wed Aug 24 13:06:34 2005 bill [...] jivesoftware.com - Ticket created

Subject:	Style improvement in commit mails
Date:	Wed, 24 Aug 2005 12:05:51 -0500
From:	"Bill Lynch" <bill [...] jivesoftware.com>
To:	<bug-svn-notify [...] rt.cpan.org>

Hello, I recently modified 2 files (see attached), specifically the output_css methods to output improved CSS (see below). Basically, I changed the colors, font and made the pre's and div's have overflow:auto so the svn mail doesn't go past the right margin of many mail clients. Attached is also a screenshot of it. I hope you find this useful and can incorporate it in the next version. Cheers, --Bill #msg DL { border : 1px #006 solid; background-color : #369; padding : 6px; color : #fff; } #msg DT { float : left; width : 6em; font-weight : bold; } #msg DL, #msg DT, #msg UL, #msg LI { font-family : arial,helvetica,sans-serif; font-size : 10pt; } h3 { font-family : arial,helvetica,sans-serif; font-size : 10pt; font-weight : bold; } #msg PRE { overflow : auto; white-space : normal; background-color : #ffc; border : 1px #fc0 solid; padding : 6px; } #msg UL, PRE, .diff { overflow : auto; } #patch h4 { font-family : arial,helvetica,sans-serif; font-size : 10pt; } #patch h4 { padding: 8px; background : #369; color : #fff; margin : 0; } #patch .propset h4, #patch .binary h4 {margin: 0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {background:#eeeeee;padding: 0 0 10px 0;} #patch .propset .diff, #patch .binary .diff {padding: 10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch .add {background:#ddffdd;} #patch .rem {background:#ffdddd;} #patch .lines, .info {color:#888888;background:#ffffff;} .diff { width : 100%; } ---------------------------------- Bill Lynch, Jive Software bill@jivesoftware.com

Download shot.gif
image/gif 53.4k

Message body is not shown because sender requested not to inline it.

Wed Aug 24 13:37:09 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	Re: [cpan #14299] Style improvement in commit mails
Date:	Wed, 24 Aug 2005 10:33:14 -0700
To:	bug-SVN-Notify [...] rt.cpan.org
RT-Send-Cc:

On Aug 24, 2005, at 10:06 AM, Bill Lynch via RT wrote: Show quoted text

> I recently modified 2 files (see attached), specifically the > output_css > methods to output improved CSS (see below). > > Basically, I changed the colors, font and made the pre's and div's > have > overflow:auto so the svn mail doesn't go past the right margin of many > mail clients. Attached is also a screenshot of it. I hope you find > this > useful and can incorporate it in the next version.

Good ideas, Bill, thanks. Can you send me a patch? Create it like this: diff -Naur SVN-Notify.orig/ SVN-Notify.new/ Thanks, David

Fri Aug 26 13:01:23 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	RE: [cpan #14299] Style improvement in commit mails
Date:	Fri, 26 Aug 2005 10:00:46 -0700
To:	bug-SVN-Notify [...] rt.cpan.org
RT-Send-Cc:

On Aug 24, 2005, at 12:47 PM, Bill Lynch via RT wrote: Show quoted text

> Attached!

Thanks Bill. This is really nice! I've applied it with the following changes: * Make verdana the preferred proportional font * Make the link color in the #msg dl kind of amber, so that it's easier to see (Mail.app defaulted to blue, which was hard to see on the blue background) * Refactored output_css() so that it didn't output the same CSS twice in ColorDiff.pm. So now it looks really slick, thanks! I've attached a new patch for you to play with. The only thing I couldn't get to work properly was, when not using HTML::ColorDiff, to have the patch output by HTML.pm do overflow:auto. I tried to put #patch { width: 100%; overflow:auto;} in, but it appeared to be ignored. Besides, I wasn't sure how it'd work with only the individual files set to overflow in ColorDiff.pm. I've attached a version as output by HTML.pm for you to play with, if you like. Let me know what you think! I'll likely get a new version out early next week. Best, David

Message body is not shown because sender requested not to inline it.

Fri Aug 26 13:09:54 2005 dwheeler [...] cpan.org - Taken

Fri Aug 26 14:55:39 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	Re: [Comment] Re: RE: [cpan #14299] Style improvement in commit mails
Date:	Fri, 26 Aug 2005 11:55:06 -0700
To:	bug-SVN-Notify [...] rt.cpan.org
RT-Send-Cc:

On Aug 26, 2005, at 10:30 AM, David Wheeler via RT wrote: Show quoted text

>> So the attached version doesn't show any highlighting on the modified >> diff part -- is that intentional? Before this section was red & green >> and I wrapped it in a box. I thought that was much easier to read. >>

> > Oh, I must've missed that in the refactoring. Which bit did I lose?

Oh, wait, the file I sent you was the output using HTML, not HTML::ColorDiff. So if you use ColorDiff, it'll still look like the file attached to this message. But for those who don't want color diffs, I'd like to be able to get overflow:auto to work for the whole patch in HTML.pm. Thanks, David

Message body is not shown because sender requested not to inline it.

Sun Sep 04 17:49:36 2005 dwheeler [...] cpan.org - Severity Wishlist added

Sun Sep 04 17:49:36 2005 dwheeler [...] cpan.org - Status changed from 'new' to 'resolved'

Sun Sep 04 17:49:37 2005 dwheeler [...] cpan.org - Fixed in 2.47 added

Bug #14299 for SVN-Notify: Style improvement in commit mails

Preferred bug tracker