Bug #14079 for Module-Build: More entries for MANIFEST.SKIP

Tue Aug 09 14:03:34 2005 chris+rt [...] chrisdolan.net - Ticket created

Subject:

More entries for MANIFEST.SKIP

The attached patch adds two new entries to the default MANIFEST.SKIP. It is against a CVS checkout from 2005-08-09 (v0.27_02). \.rej$ These are patch rejection files, and represent an error case, not normal files. \b\.DS_Store$ These are metadata files that the Mac OS X file browser leaves in many directories.

Index: lib/Module/Build/Base.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.472 diff -u -b -r1.472 Base.pm --- lib/Module/Build/Base.pm 4 Aug 2005 06:47:34 -0000 1.472 +++ lib/Module/Build/Base.pm 9 Aug 2005 17:59:45 -0000 @@ -2432,6 +2432,8 @@ \.bak$ \#$ \b\.# +\b\.DS_Store$ +\.rej$ EOF $fh->close();

Thu Sep 22 14:48:19 2005 cpan [...] clotho.com - Correspondence added

Here's another version of this patch. This one adds the following to the default MANIFEST.SKIP: * skip .cvsignore files * skip cover_db directories * skip patch rejection files (*.rej) * skip OS metadata (.DS_Store or ._*) * skip distribution archives (like Module-Build-0.27.tar.gz) -- Chris

Index: lib/Module/Build/Base.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.481 diff -u -b -r1.481 Base.pm --- lib/Module/Build/Base.pm 22 Sep 2005 02:39:34 -0000 1.481 +++ lib/Module/Build/Base.pm 22 Sep 2005 18:46:11 -0000 @@ -2491,14 +2491,16 @@ my $fh = IO::File->new("> $file") or die "Can't open $file: $!"; - # This is pretty much straight out of - # MakeMakers default MANIFEST.SKIP file + # This is derived from MakeMaker's default MANIFEST.SKIP file with + # some new entries + print $fh <<'EOF'; # Avoid version control files. \bRCS\b \bCVS\b ,v$ \B\.svn\b +\b\.cvsignore$ # Avoid Makemaker generated and utility files. \bMakefile$ @@ -2512,6 +2514,9 @@ \bBuild$ \b_build +# Avoid Devel::Cover generated files +\bcover_db + # Avoid temp and backup files. ~$ \.tmp$ @@ -2519,8 +2524,19 @@ \.bak$ \#$ \b\.# +\.rej$ + +# Avoid OS-specific files/dirs +# Mac OSX metadata +\b\.DS_Store +# Mac OSX SMB mount metadata files +\b\._ +# Avoid archives of this distribution EOF + # Skip, for example, "Module-Build-0.27.tar.gz' + print $fh '\b'.$self->dist_name.'-[\d\.\_]+'."\n"; + $fh->close(); }

Mon Sep 26 23:11:32 2005 kwilliams [...] cpan.org - Correspondence added

Thanks, applied. -Ken

Mon Sep 26 23:11:33 2005 kwilliams [...] cpan.org - Status changed from 'new' to 'resolved'