| Subject: | patch to support multiple subattributes in one VSA |
There is a simple patch to support multiple attr/value pairs in one VSA value. (At least one known client does send such a messages - accounting in BroadSoft.) It's ok according to RFC 2825 5.26 final clause.
Also, it could be nice to make these modules more robust, like checking for errors in readline subroutine of Dictionary.pm and so on
304c304,308
< my ($vid, $vtype, $vlength) = unpack "N C C", $value;
---
> my ($vid) = unpack "N", $value;
> substr ($value, 0, 4) = "";
>
> while (length($value)) {
> my ($vtype, $vlength) = unpack "C C", $value;
316,317c320,321
< ($vid, $vtype) = unpack "N N", $value;
< $vvalue = unpack "xxxx xxxx a${\($length-10)}", $value;
---
> ($vtype) = unpack "N", $value;
> $vvalue = unpack "xxxx a${\($length-10)}", $value;
319c323
< $vvalue = unpack "xxxx x x a${\($vlength-2)}", $value;
---
> $vvalue = unpack "x x a${\($vlength-2)}", $value;
338a343,346
>
> substr($value, 0, $vlength) = "";
> }
>