| Subject: | cvs: missing ppport.h + too strict test(?) |
This is for the cvs version of PPI::XS.
When running nmake, I get:
XS.xs(4) : fatal error C1083: Cannot open include file: 'ppport.h': No such file or directory
After a quick Google, I found the Devel::PPPort module. Maybe adding something like this to the Makefile.PL works?
build_requires( 'Devel::PPPort' => 0 );
...
use Devel::PPPort;
Devel::PPPort::WriteFile();
Now it compiles fine (with some warnings: "XS.c(29) : warning C4101: 'RETVAL' : unreferenced local variable".)
(However, when doing that, the tests fail with this:
C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'in
c', 'blib\lib', 'blib\arch')" t/01_compile.t t/02_autoload.t t/03_integration.t
t/04_significant.t t/05_destroy.t
t/01_compile........ok
t/02_autoload.......ok
t/03_integration....ok
t/04_significant....ok 6/12
t/04_significant....NOK 12# Failed test (t/04_significant.t at line 50)
# got: undef
# expected: ''
# Looks like you failed 1 test of 12.
t/04_significant....dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 12
Failed 1/12 tests, 91.67% okay
t/05_destroy........ok
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
t/04_significant.t 1 256 12 1 8.33% 12
Failed 1/5 test scripts, 80.00% okay. 1/34 subtests failed, 97.06% okay.
NMAKE : fatal error U1077: 'C:\Perl\bin\perl.exe' : return code '0xff'
Stop.
Changing the test on line 50 to
ok( ! PPI::Token::End->significant, 'PPI::Token::End->significant returns false' );
fixes that, and it seems semantically more correct judging from the test comment.