Bug #13571 for LJ-Simple: Test crashes

Thu Jul 07 07:51:08 2005 Guest - Ticket created

Subject:

Test crashes

Thanks for nice module. I didn't yet use it. Just tryed to install and found that problem. The test craches because LJ::Simple object is not defined. I've created a patch for test.pl. First, I've put checking if LJ::Simple object is exists or not. It allows to pass tests without connection to the LiveJournal.com. Second, I've added possibility to retrieve a proxy from environment. Because it's needed when your module is installed using CPAN.pm Hope, it'll help you.

Message body is not shown because it is too large.

Thu Jul 07 09:56:26 2005 simes [...] bpfh.net - Given to SIMES

Thu Jul 07 09:58:13 2005 simes [...] bpfh.net - Correspondence added

Show quoted text

> The test craches because LJ::Simple object is not defined.

Can you please attach the output of the unpatched test.pl please ? Can you also let me know what version of perl you are using ? Thanks

Thu Jul 07 09:58:13 2005 simes [...] bpfh.net - Status changed from 'new' to 'open'

Thu Jul 07 10:10:56 2005 STEPANOV [...] cpan.org - Correspondence added

[SIMES - Thu Jul 7 09:58:13 2005]: Show quoted text

> > The test craches because LJ::Simple object is not defined.

> > Can you please attach the output of the unpatched test.pl please ? > Can you also let me know what version of perl you are using ? > > Thanks

This is an output of original test.pl: PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..35 # Running under perl version 5.008006 for linux # Current time local: Thu Jul 7 17:03:24 2005 # Current time GMT: Thu Jul 7 14:03:24 2005 # Using Test.pm version 1.25 ok 1 ok 2 ok 3 ok 4 ok 5 ok 6 ok 7 ok 8 ok 9 ok 10 ok 11 ok 12 ok 13 ok 14 ok 15 not ok 16 # Failed test 16 in test.pl at line 120 # test.pl line 120 is: if (defined $lj) {ok(1)} else {ok(0)} Can't call method "moods" on an undefined value at test.pl line 122. make: *** [test_dynamic] Error 111 I have Perl v5.8.6. Two problems in your test.pl: 1) There is not a possibility to specify proxy if that module is istalled using cpan shell. 2) When LJ::Simple object is creating you just check if it defined in one place (line 120, for example) and if it isn't defined it gives a error "Can't call method "moods" on an undefined value". Also, could you tell me, please, is it possible to know a number of comments for specific post?

Thu Jul 07 11:56:37 2005 simes [...] bpfh.net - Correspondence added

[STEPANOV - Thu Jul 7 10:10:56 2005]: Show quoted text

> # Running under perl version 5.008006 for linux > I have Perl v5.8.6.

However the test harness is being run under 5.008006 Show quoted text

> 1) There is not a possibility to specify proxy if that module is > istalled using cpan shell.

Hmmmm; I'll think about the best way to fix this at the module level I think. Show quoted text

> 2) When LJ::Simple object is creating you just check if it defined in > one place (line 120, for > example) and if it isn't defined it gives a error "Can't call method > "moods" on an undefined > value".

I'll look at a suitable way to fix this. Show quoted text

> Also, could you tell me, please, is it possible to know a number of > comments for specific post?

Unfortunately its not possible to do this with the client protocol so its not supported.

Fri Jul 08 07:10:48 2005 simes [...] bpfh.net - Correspondence added

Okay, the issues you've reported have now been fixed in version 0.13 of LJ::Simple which I've just released.

Fri Jul 08 07:10:48 2005 simes [...] bpfh.net - Status changed from 'open' to 'resolved'