| Subject: | Missing check for MP3::Tag for example |
Very cool to see a module for shoutcast streams. :-)
When running the example, I noticed that it required MP3::Tag. Perhaps you could list it as an optional pre-req in Makefile.PL, and/or mention it in the README?
Also, when running the example, I got the following:
bryce@blackwold} ~/Build/Netx-WebRadio-0.03/Examples/FileWriter (30): perl shoutcast_client.pl
Use of uninitialized value in pattern match (m//) at Netx/WebRadio/Station/Shoutcast/FileWriter.pm line 53.
error in station
at shoutcast_client.pl line 36
Use of uninitialized value in pattern match (m//) at Netx/WebRadio/Station/Shoutcast/FileWriter.pm line 53.
error in station
at shoutcast_client.pl line 36
all connections closed
This patch suppressed the error:
--- FileWriter.pm~ 2003-01-13 13:28:23.000000000 -0800
+++ FileWriter.pm 2005-07-04 12:45:34.000000000 -0700
@@ -48,7 +48,7 @@
sub close_old_file {
my $self = shift;
- my $title = $self->{_actualTitle};
+ my $title = $self->{_actualTitle} || '';
my $filename = $self->{ _actualFilename };
my ($artist, $song) = $title =~ /(.*?) - (.*)/;
close $self->{ _fh } if $self->{ _fh };
However, it then failed like this:
{bryce@blackwold} ~/Build/Netx-WebRadio-0.03/Examples/FileWriter (32): perl shoutcast_client.pl
connect successful
connect successful
error in station
at shoutcast_client.pl line 36
error in station
at shoutcast_client.pl line 36
all connections closed
Here's a patch to improve the warnings:
--- shoutcast_client.pl~ 2005-07-04 12:41:24.000000000 -0700
+++ shoutcast_client.pl 2005-07-04 12:55:42.000000000 -0700
@@ -28,12 +28,12 @@
$receiver->add_station( $station );
print "connect successful\n";
} else {
- print "connect NOT successfull\n";
+ print "connect NOT successful\n";
}
}
while ($receiver->number_of_stations) {
- $receiver->receive();
+ $receiver->receive() or print "Could not receive from station\n";
}
print "all connections closed\n";
Anyway, hope this helps, keep up the good work.