Subject: | PAM.xs: plain C functions should be static |
Hello,
get_perl_pam_data() and my_delay_func() in PAM.xs should be static functions, shouldn't they?
--- Authen-PAM-0.16/PAM.xs- 2004-12-09 06:05:59 +0000
+++ Authen-PAM-0.16/PAM.xs 2005-06-30 05:46:32 +0000
@@ -61,7 +61,7 @@ typedef struct perl_pam_data sPerlPamDat
/*
* Gets conv_struct->appdata_ptr and casts it as a sPerlPamData
*/
-sPerlPamData*
+static sPerlPamData*
get_perl_pam_data(pamh)
pam_handle_t *pamh;
{
@@ -184,7 +184,7 @@ my_conv_func(num_msg, msg, resp, appdata
*
* Works only on Linux-PAM >= 0.68
*/
-void
+static void
my_delay_func(status, delay, appdata_ptr)
int status;
unsigned int delay;
End of patch
--
Alexey Tourbin
ALT Linux Team