Bug #133876 for Lingua-EN-Inflect: Env is not needed/used

Mon Dec 07 15:12:02 2020 rkleemann [...] gmail.com - Ticket created

Subject:	Env is not needed/used
Date:	Mon, 7 Dec 2020 12:11:41 -0800
To:	bug-Lingua-EN-Inflect [...] rt.cpan.org
From:	Bob Kleemann <rkleemann [...] gmail.com>

Line 5 of Lingua/EN/Inflect.pm uses the module Env, but none of the following lines appear to actually use the module. I commented out the line, and then ran "perl Makefile.PL && make && make test", which successfully ran to completion. I searched for all instances of "[@$][[:upper:]]+(?:_[[:upper:]]+)*\b" in Inflect.pm, and found that they're all Perl variables, and not environment variables that might have been imported. This also addresses the issue that Env is not listed in the prerequisites in META.{json,yml}, nor in Makefile.PL. That issue I ran across while trying to build a docker container.

Tue Dec 08 01:43:33 2020 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #133876] Env is not needed/used
Date:	Tue, 8 Dec 2020 06:42:41 +0000
To:	bug-Lingua-EN-Inflect [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Hi Bob, Thanks for the report. Line 859 of Inflect.pm uses the module to find the user's home directory. It's not tested in the test suite, but I think it's still needed. I'd be happy to discuss it further, if you feel otherwise. BTW, it isn't flagged in the metadata because Env.pm is a core module. Damian

Tue Dec 08 01:43:34 2020 The RT System itself - Status changed from 'new' to 'open'

Tue Dec 08 11:23:01 2020 rkleemann [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #133876] Env is not needed/used
Date:	Tue, 8 Dec 2020 08:22:33 -0800
To:	bug-Lingua-EN-Inflect [...] rt.cpan.org
From:	Bob Kleemann <rkleemann [...] gmail.com>

Hi Damian, Line 859 ($rcfile = "$ENV{HOME}/.inflectrc" || '';) doesn't use the Per module Env, it uses %ENV, which is a Perl variable that's available without the module. Since line 859 is the only line that mentions [%$]ENV, you could safely remove line 5 and not have anything break in your module. As for Env being included in the core distribution, I've looked, and you're right, it's there. The Linux distribution I'm using must not include it with the default Perl. Bob On Mon, Dec 7, 2020 at 10:43 PM damian@conway.org via RT < bug-Lingua-EN-Inflect@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=133876 > > > Hi Bob, > > Thanks for the report. > > Line 859 of Inflect.pm uses the module to find the user's home directory. > It's not tested in the test suite, but I think it's still needed. > I'd be happy to discuss it further, if you feel otherwise. > > BTW, it isn't flagged in the metadata because Env.pm is a core module. > > Damian > >

Tue Dec 08 14:21:17 2020 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #133876] Env is not needed/used
Date:	Tue, 8 Dec 2020 19:20:24 +0000
To:	bug-Lingua-EN-Inflect [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Thanks for the follow-up, Bob. You're quite right, of course: %ENV doesn't require Env (that will teach me to look at bug reports when I'm not well ;-) I'll remove the unnecessary dependency and re-release today. Much appreciated, Damian

Tue Dec 08 14:22:03 2020 DCONWAY [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Dec 08 14:26:38 2020 rkleemann [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #133876] Env is not needed/used
Date:	Tue, 8 Dec 2020 11:26:19 -0800
To:	bug-Lingua-EN-Inflect [...] rt.cpan.org
From:	Bob Kleemann <rkleemann [...] gmail.com>

Thanks, and get well soon. On Tue, Dec 8, 2020 at 11:21 AM damian@conway.org via RT < bug-Lingua-EN-Inflect@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=133876 > > > Thanks for the follow-up, Bob. > > You're quite right, of course: %ENV doesn't require Env > (that will teach me to look at bug reports when I'm not well ;-) > > I'll remove the unnecessary dependency and re-release today. > > Much appreciated, > > Damian > >