Bug #133814 for Type-Tiny: Please add ->check_coerce method which returns undef if coercion fails

Thu Nov 26 12:10:22 2020 bpjonsson [...] gmail.com - Ticket created

Subject:	Please add ->check_coerce method which returns undef if coercion fails
Date:	Thu, 26 Nov 2020 18:10:02 +0100
To:	bug-Type-Tiny [...] rt.cpan.org
From:	BP Jonsson <bpjonsson [...] gmail.com>

The subject pretty much says it all. There is ->coerce which returns the original value if coercion fails, and ->assert_coerce which dies if coercion fails but no middle ground which returns false if coercion fails. It is true that it would just be sugar for Type->check( Type->coerce($value) ) but it would be very useful sugar, because frankly those nested calls are ugly, especially when it's inside an if test which is commonly the case, and even more so in case you use a coercion object: Coercion->type_constraint(Coercion->coerce($value))! I'm tempted to use try { Foo->assert_coerce($value) } but that is really even more ugly, although less to type. I can try to make a pull request if it would be welcome.

Thu Nov 26 13:42:18 2020 ether [...] cpan.org - Correspondence added

On 2020-11-26 09:10:22, bpjonsson@gmail.com wrote: Show quoted text

> The subject pretty much says it all. There is ->coerce which returns the > original value if coercion fails, and ->assert_coerce which dies if > coercion fails but no middle ground which returns false if coercion fails.

FWIW, there is no such interface in Moose::Meta::TypeConstraint, which Type::Tiny emulates (so as to allow for seamless replacement of Moose types with Type::Tiny types in Moose classes).

Thu Nov 26 13:42:19 2020 The RT System itself - Status changed from 'new' to 'open'

Thu Nov 26 14:44:35 2020 bpj [...] melroch.se - Correspondence added

CC:	BP Jonsson <bpjonsson [...] gmail.com>
Subject:	Re: [rt.cpan.org #133814] Please add ->check_coerce method which returns undef if coercion fails
Date:	Thu, 26 Nov 2020 20:44:10 +0100
To:	bug-Type-Tiny [...] rt.cpan.org
From:	BPJ <bpj [...] melroch.se>

Den tors 26 nov. 2020 19:43Karen Etheridge via RT <bug-Type-Tiny@rt.cpan.org> skrev: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=133814 > > > On 2020-11-26 09:10:22, bpjonsson@gmail.com wrote:

> > The subject pretty much says it all. There is ->coerce which returns the > > original value if coercion fails, and ->assert_coerce which dies if > > coercion fails but no middle ground which returns false if coercion

> fails. > > FWIW, there is no such interface in Moose::Meta::TypeConstraint, which > Type::Tiny emulates (so as to allow for seamless replacement of Moose types > with Type::Tiny types in Moose classes). >

So what? Moose won't use the method so no harm if it exists. Type::Tiny has other methods without a Moose counterpart, notably ->assert_return, which makes sense because Type::Tiny can conveniently be used to validate and coerce any value anywhere, not just in Moo(se) attribute declarations. In those cases these "extra" methods make sense.

Sun Nov 29 20:03:12 2020 perl [...] toby.ink - Correspondence added

I have thought for a while of adding a default coercion to Maybe[Foo] whenever Foo has a coercion. So then you could do: my $coerced_value_or_undef = Maybe->of(Foo)->coerce($orig_value);

Mon Nov 30 11:22:53 2020 melroch [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #133814] Please add ->check_coerce method which returns undef if coercion fails
Date:	Mon, 30 Nov 2020 17:22:40 +0100
To:	bug-Type-Tiny [...] rt.cpan.org
From:	BP Jonsson <melroch [...] gmail.com>

On 2020-11-30 02:03, Toby Inkster via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=133814 > > > I have thought for a while of adding a default coercion to Maybe[Foo] whenever Foo has a coercion. > > So then you could do: > > my $coerced_value_or_undef = Maybe->of(Foo)->coerce($orig_value); >

I like it, except that if it is to be used more than once that Maybe->of(Foo) needs to be stored somewhere. I guess that's what state variables are for, but it is one more thing to keep track of.

Tue Dec 01 12:34:57 2020 perl [...] toby.ink - Correspondence added

Type::Tiny does internally cache the result of $type1->of($type2) to avoid a lot of the internal construction stuff the second time it's called. Of course, sticking it in a state variable and reusing it will be even better. Like the following should output the same refaddr twice: use strict; use warnings; use feature 'say'; use Scalar::Util 'refaddr'; use Types::Standard -types; my $x = Maybe->of( Int ); say refaddr( $x ); undef $x; my $y = Maybe->of( Int ); say refaddr( $y );

Thu Dec 03 04:15:19 2020 bpj [...] melroch.se - Correspondence added

CC:	BP Jonsson <bpjonsson [...] gmail.com>
Subject:	Re: [rt.cpan.org #133814] Please add ->check_coerce method which returns undef if coercion fails
Date:	Thu, 3 Dec 2020 10:15:01 +0100
To:	bug-Type-Tiny [...] rt.cpan.org
From:	BPJ <bpj [...] melroch.se>

Den tis 1 dec. 2020 18:35Toby Inkster via RT <bug-Type-Tiny@rt.cpan.org> skrev: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=133814 > > > Type::Tiny does internally cache the result of $type1->of($type2) to avoid > a lot of the internal construction stuff the second time it's called.

OK, good to know. I usually meticulously save my derived types under a new name or in a variable but this can make things easier. Of course, sticking it in a state variable and reusing it will be even Show quoted text

> better. >

It also reduces the amount of typing in the long run even if the derived type is called $MaybeInt, give or take a sigil. Show quoted text

> Like the following should output the same refaddr twice: > > > use strict; > use warnings; > use feature 'say'; > use Scalar::Util 'refaddr'; > use Types::Standard -types; > > my $x = Maybe->of( Int ); > say refaddr( $x ); > > undef $x; > > my $y = Maybe->of( Int ); > say refaddr( $y ); > >