Skip Menu |

This queue is for tickets about the Graphics-TIFF CPAN distribution.

Report information
The Basics
Id: 133724
Status: resolved
Priority: 0/
Queue: Graphics-TIFF

People
Owner: jffry [...] posteo.net
Requestors: TVIGNAUD [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: t/93_tiff2pdf.t fails with libtiff-progs-4.1.0 (git20201026) b/c of new -m option
t/93_tiff2pdf.t fails with libtiff-progs-4.1.0 (git20201026) b/c of new -m option: " -m: set memory allocation limit (in MiB). set to 0 to disable limit" The attached patch workarounds that. # Failed test '-?' # at t/93_tiff2pdf.t line 29. # got: 'tiff2pdf: invalid option -- ? # LIBTIFF, Version 4.1.0 # Copyright (c) 1988-1996 Sam Leffler # Copyright (c) 1991-1996 Silicon Graphics, Inc. # # usage: tiff2pdf [options] input.tiff # options: # -o: output to file name # -j: compress with JPEG # -z: compress with Zip/Deflate # -q: compression quality # -n: no compressed data passthrough # -d: do not compress (decompress) # -i: invert colors # -u: set distance unit, 'i' for inch, 'm' for centimeter # -x: set x resolution default in dots per unit # -y: set y resolution default in dots per unit # -w: width in units # -l: length in units # -r: 'd' for resolution default, 'o' for resolution override # -p: paper size, eg "letter", "legal", "A4" # -F: make the tiff fill the PDF page # -f: set PDF "Fit Window" user preference # -e: date, overrides image or current date/time default, YYYYMMDDHHMMSS # -c: sets document creator, overrides image software default # -a: sets document author, overrides image artist default # -t: sets document title, overrides image document name default # -s: sets document subject, overrides image image description default # -k: sets document keywords # -b: set PDF "Interpolate" user preference # -h: usage # ' # expected: 'tiff2pdf: invalid option -- ? # LIBTIFF, Version 4.1.0 # Copyright (c) 1988-1996 Sam Leffler # Copyright (c) 1991-1996 Silicon Graphics, Inc. # # usage: tiff2pdf [options] input.tiff # options: # -o: output to file name # -j: compress with JPEG # -z: compress with Zip/Deflate # -q: compression quality # -n: no compressed data passthrough # -d: do not compress (decompress) # -i: invert colors # -u: set distance unit, 'i' for inch, 'm' for centimeter # -x: set x resolution default in dots per unit # -y: set y resolution default in dots per unit # -w: width in units # -l: length in units # -r: 'd' for resolution default, 'o' for resolution override # -p: paper size, eg "letter", "legal", "A4" # -F: make the tiff fill the PDF page # -f: set PDF "Fit Window" user preference # -e: date, overrides image or current date/time default, YYYYMMDDHHMMSS # -c: sets document creator, overrides image software default # -a: sets document author, overrides image artist default # -t: sets document title, overrides image document name default # -s: sets document subject, overrides image image description default # -k: sets document keywords # -b: set PDF "Interpolate" user preference # -m: set memory allocation limit (in MiB). set to 0 to disable limit # -h: usage # ' # Looks like you failed 1 test of 4.
Subject: Graphics-TIFF-fixes.patch
# fix new optiion in tiff2pdf diff -up ./t/93_tiff2pdf.t.tv ./t/93_tiff2pdf.t --- ./t/93_tiff2pdf.t.tv 2020-10-27 12:57:55.000000000 +0100 +++ ./t/93_tiff2pdf.t 2020-11-11 16:03:19.822865454 +0100 @@ -26,6 +26,8 @@ my $make_reproducible = # strip '' from around ?, which newer glibc libraries seem to have added my $expected = `tiff2pdf -? $tif 2>&1`; $expected =~ s/'\?'/?/xsm; +# (tv) unsupported new -m option: +$expected =~ s/^.*-m: set memory allocation limit \(in MiB\). set to 0 to disable limit.*\n//m; is( `$cmd -? $tif 2>&1`, $expected, '-?' ); #########################
Thanks for the patch. Committed.