Skip Menu |

This queue is for tickets about the Alien-XPA CPAN distribution.

Report information
The Basics
Id: 133699
Status: open
Priority: 0/
Queue: Alien-XPA

People
Owner: Nobody in particular
Requestors: gabor [...] szabgab.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: could not run dzil test on cloned repo
Date: Sat, 7 Nov 2020 23:08:09 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
I am not very familiar with Dist Zilla so I might be doing something wrong: I cloned the repository from https://gitlab.com/djerius/Alien-XPA.git and then ran dzil authordeps --missing | cpanm then tried: dzil listdeps --author --missing | cpanm and I got this error: Pod::Weaver::Section::BugsAndLimitations (for section BugsAndLimitations) does not appear to be installed with a long trace. After manually installing that module I ran dzil listdeps again. This time I got Pod::Weaver::Section::SeeAlso (for section SeeAlso) does not appear to be installed After installing that too I was already fine. Then I tried: $ dzil test and got: [DZ] building distribution under .build/clpDu3F4gK for installation [DZ] beginning to build Alien-XPA [DZ] guessing dist's main_module is lib/Alien/XPA.pm [DZ] writing Alien-XPA in .build/clpDu3F4gK [ReadmeAnyFromPod] overriding README.mkdn in root [EnsurePrereqsInstalled] dynamic_config is set: make sure you put all possible prereqs into develop prereqs so your tests are complete! [EnsurePrereqsInstalled] Unsatisfied prerequisites: [EnsurePrereqsInstalled] Module 'Action::Retry' is not installed [EnsurePrereqsInstalled] Module 'Child' is not installed [EnsurePrereqsInstalled] To remedy, do: cpanm Action::Retry Child [EnsurePrereqsInstalled] Unsatisfied prerequisites: [EnsurePrereqsInstalled] Module 'Action::Retry' is not installed [EnsurePrereqsInstalled] Module 'Child' is not installed [EnsurePrereqsInstalled] To remedy, do: cpanm Action::Retry Child at inline delegation in Dist::Zilla::Plugin::EnsurePrereqsInstalled for logger->log_fatal (attribute declared in /home/gabor/perl5/lib/perl5/Dist/Zilla/Role/Plugin.pm at line 59) line 18. I wonder, is there a dzil command I should run to install all of these dependencies?

Message body is not shown because it is too large.

On 2020-11-07 13:08:39, gabor@szabgab.com wrote: Show quoted text
> I wonder, is there a dzil command I should run to install all of these > dependencies?
dist.ini needs to contain the lines: ; authordeps Pod::Weaver::Section::BugsAndLimitations ; authordeps Pod::Weaver::Section::SeeAlso ... and then you can install everything with 'dzil authordeps --missing | cpanm; dzil listdeps --missing | cpanm'.
On Sat Nov 07 16:08:39 2020, gabor@szabgab.com wrote: Show quoted text
> I am not very familiar with Dist Zilla so I might be doing something wrong: > > I cloned the repository from https://gitlab.com/djerius/Alien-XPA.git > and then ran > > dzil authordeps --missing | cpanm > > then tried: > > dzil listdeps --author --missing | cpanm > > and I got this error: > > Pod::Weaver::Section::BugsAndLimitations (for section BugsAndLimitations) > does not appear to be installed > > with a long trace. > > After manually installing that module I ran > > dzil listdeps > > again. This time I got > > Pod::Weaver::Section::SeeAlso (for section SeeAlso) does not appear to be > installed > > After installing that too I was already fine. > > > Then I tried: > > $ dzil test > > and got: > > > [DZ] building distribution under .build/clpDu3F4gK for installation > [DZ] beginning to build Alien-XPA > [DZ] guessing dist's main_module is lib/Alien/XPA.pm > [DZ] writing Alien-XPA in .build/clpDu3F4gK > [ReadmeAnyFromPod] overriding README.mkdn in root > [EnsurePrereqsInstalled] dynamic_config is set: make sure you put all > possible prereqs into develop prereqs so your tests are complete! > [EnsurePrereqsInstalled] Unsatisfied prerequisites: > [EnsurePrereqsInstalled] Module 'Action::Retry' is not installed > [EnsurePrereqsInstalled] Module 'Child' is not installed > [EnsurePrereqsInstalled] To remedy, do: cpanm Action::Retry Child > [EnsurePrereqsInstalled] Unsatisfied prerequisites: > [EnsurePrereqsInstalled] Module 'Action::Retry' is not installed > [EnsurePrereqsInstalled] Module 'Child' is not installed > [EnsurePrereqsInstalled] To remedy, do: cpanm Action::Retry Child at > inline delegation in Dist::Zilla::Plugin::EnsurePrereqsInstalled for > logger->log_fatal (attribute declared in > /home/gabor/perl5/lib/perl5/Dist/Zilla/Role/Plugin.pm at line 59) line 18. > > > > I wonder, is there a dzil command I should run to install all of these > dependencies?
Hi, Thanks for trying out the code. You don't need dzil to work on the repo; the repo contains a pre-generated Makefile.PL that you can use directly. There's also a pre-generated cpanfile, so you can simply run cpanm --installdeps . To get all of the configure/build/test dependencies. Diab
On Sat Nov 07 16:39:12 2020, ETHER wrote: Show quoted text
> On 2020-11-07 13:08:39, gabor@szabgab.com wrote: >
> > I wonder, is there a dzil command I should run to install all of > > these > > dependencies?
> > dist.ini needs to contain the lines: > > ; authordeps Pod::Weaver::Section::BugsAndLimitations > ; authordeps Pod::Weaver::Section::SeeAlso > > ... and then you can install everything with 'dzil authordeps > --missing | cpanm; dzil listdeps --missing | cpanm'.
You know, I always forget the Pod::Weaver ones. Thanks !
Subject: Re: [rt.cpan.org #133699] could not run dzil test on cloned repo
Date: Sat, 7 Nov 2020 23:47:23 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
Thanks. Actually I am trying to set up a GitLab pipeline and then send it to you in Merge request. I thought it would be better to start from the dzil code.
On Sat Nov 07 16:44:00 2020, DJERIUS wrote: Show quoted text
> On Sat Nov 07 16:08:39 2020, gabor@szabgab.com wrote:
> > I am not very familiar with Dist Zilla so I might be doing something > > wrong: > > > > I cloned the repository from https://gitlab.com/djerius/Alien- > > XPA.git > > and then ran > > > > dzil authordeps --missing | cpanm > > > > then tried: > > > > dzil listdeps --author --missing | cpanm > > > > and I got this error: > > > > Pod::Weaver::Section::BugsAndLimitations (for section > > BugsAndLimitations) > > does not appear to be installed > > > > with a long trace. > > > > After manually installing that module I ran > > > > dzil listdeps > > > > again. This time I got > > > > Pod::Weaver::Section::SeeAlso (for section SeeAlso) does not appear > > to be > > installed > > > > After installing that too I was already fine. > > > > > > Then I tried: > > > > $ dzil test > > > > and got: > > > > > > [DZ] building distribution under .build/clpDu3F4gK for installation > > [DZ] beginning to build Alien-XPA > > [DZ] guessing dist's main_module is lib/Alien/XPA.pm > > [DZ] writing Alien-XPA in .build/clpDu3F4gK > > [ReadmeAnyFromPod] overriding README.mkdn in root > > [EnsurePrereqsInstalled] dynamic_config is set: make sure you put all > > possible prereqs into develop prereqs so your tests are complete! > > [EnsurePrereqsInstalled] Unsatisfied prerequisites: > > [EnsurePrereqsInstalled] Module 'Action::Retry' is not installed > > [EnsurePrereqsInstalled] Module 'Child' is not installed > > [EnsurePrereqsInstalled] To remedy, do: cpanm Action::Retry Child > > [EnsurePrereqsInstalled] Unsatisfied prerequisites: > > [EnsurePrereqsInstalled] Module 'Action::Retry' is not installed > > [EnsurePrereqsInstalled] Module 'Child' is not installed > > [EnsurePrereqsInstalled] To remedy, do: cpanm Action::Retry Child at > > inline delegation in Dist::Zilla::Plugin::EnsurePrereqsInstalled for > > logger->log_fatal (attribute declared in > > /home/gabor/perl5/lib/perl5/Dist/Zilla/Role/Plugin.pm at line 59) > > line 18. > > > > > > > > I wonder, is there a dzil command I should run to install all of > > these > > dependencies?
> > Hi, > > Thanks for trying out the code. > > You don't need dzil to work on the repo; the repo contains a pre- > generated Makefile.PL that you can use directly. > > There's also a pre-generated cpanfile, so you can simply run > > cpanm --installdeps . > > To get all of the configure/build/test dependencies. > > Diab
I should add some "how to contribute" documentation to indicate that.
On Sat Nov 07 16:47:39 2020, gabor@szabgab.com wrote: Show quoted text
> Thanks. > Actually I am trying to set up a GitLab pipeline and then send it to you in > Merge request. > I thought it would be better to start from the dzil code.
Ahh. Thanks, that would be most helpful. I'm having a devil of a time trying to figure out what exactly is causing build/test failures on CPAN for what seem to be almost identical platforms.
Subject: Re: [rt.cpan.org #133699] could not run dzil test on cloned repo
Date: Sun, 8 Nov 2020 00:04:45 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
Show quoted text
> Ahh. Thanks, that would be most helpful. I'm having a devil of a time > trying to figure out what exactly is causing build/test failures on CPAN > for what seem to be almost identical platforms.
Something seems to also require Sort::Versions, but I have not understood yet what because I don't see it anywhere in the repo.
On Sat Nov 07 17:05:08 2020, gabor@szabgab.com wrote: Show quoted text
> > Ahh. Thanks, that would be most helpful. I'm having a devil of a time > > trying to figure out what exactly is causing build/test failures on CPAN > > for what seem to be almost identical platforms.
> > > Something seems to also require Sort::Versions, but I have not understood > yet what because I don't see it anywhere in the repo.
That's bizarre; the dependency tree from CPAN doesn't show that (but doesn't seem to go that deep): https://cpandeps.grinnz.com/?dist=Alien-XPA&dist_version=&phase=test&perl_version=v5.30.2&style=auto
On Sat Nov 07 17:10:51 2020, DJERIUS wrote: Show quoted text
> On Sat Nov 07 17:05:08 2020, gabor@szabgab.com wrote:
> > > Ahh. Thanks, that would be most helpful. I'm having a devil of a > > > time > > > trying to figure out what exactly is causing build/test failures on > > > CPAN > > > for what seem to be almost identical platforms.
> > > > > > Something seems to also require Sort::Versions, but I have not > > understood > > yet what because I don't see it anywhere in the repo.
> > > That's bizarre; the dependency tree from CPAN doesn't show that (but > doesn't seem to go that deep): > > https://cpandeps.grinnz.com/?dist=Alien- > XPA&dist_version=&phase=test&perl_version=v5.30.2&style=auto
Oh, wait; do you mean the dzil dependencies?
Subject: Re: [rt.cpan.org #133699] could not run dzil test on cloned repo
Date: Sun, 8 Nov 2020 00:14:11 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
On Sat, Nov 7, 2020 at 11:39 PM Karen Etheridge via RT < bug-Alien-XPA@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=133699 > > > On 2020-11-07 13:08:39, gabor@szabgab.com wrote: >
> > I wonder, is there a dzil command I should run to install all of these > > dependencies?
> > dist.ini needs to contain the lines: > > ; authordeps Pod::Weaver::Section::BugsAndLimitations > ; authordeps Pod::Weaver::Section::SeeAlso > > ... and then you can install everything with 'dzil authordeps --missing | > cpanm; dzil listdeps --missing | cpanm'. > >
Shall I send a Merge Request with this change? Gabor
On Sat Nov 07 16:46:53 2020, DJERIUS wrote: Show quoted text
> On Sat Nov 07 16:39:12 2020, ETHER wrote:
> > On 2020-11-07 13:08:39, gabor@szabgab.com wrote: > >
> > > I wonder, is there a dzil command I should run to install all of > > > these > > > dependencies?
> > > > dist.ini needs to contain the lines: > > > > ; authordeps Pod::Weaver::Section::BugsAndLimitations > > ; authordeps Pod::Weaver::Section::SeeAlso > > > > ... and then you can install everything with 'dzil authordeps > > --missing | cpanm; dzil listdeps --missing | cpanm'.
> > > You know, I always forget the Pod::Weaver ones. Thanks !
Hmm. I have them listed under [Prereqs / DevelopRequires]. Shouldn't that automatically label them as authordeps? In my mind Develop/Author is the same thing.
Subject: Re: [rt.cpan.org #133699] could not run dzil test on cloned repo
Date: Sun, 8 Nov 2020 00:20:14 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
On Sun, Nov 8, 2020 at 12:17 AM Diab Jerius via RT < bug-Alien-XPA@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=133699 > > > On Sat Nov 07 16:46:53 2020, DJERIUS wrote:
> > On Sat Nov 07 16:39:12 2020, ETHER wrote:
> > > On 2020-11-07 13:08:39, gabor@szabgab.com wrote: > > >
> > > > I wonder, is there a dzil command I should run to install all of > > > > these > > > > dependencies?
> > > > > > dist.ini needs to contain the lines: > > > > > > ; authordeps Pod::Weaver::Section::BugsAndLimitations > > > ; authordeps Pod::Weaver::Section::SeeAlso > > > > > > ... and then you can install everything with 'dzil authordeps > > > --missing | cpanm; dzil listdeps --missing | cpanm'.
> > > > > > You know, I always forget the Pod::Weaver ones. Thanks !
> > Hmm. I have them listed under [Prereqs / DevelopRequires]. Shouldn't that > automatically label them as authordeps? In my mind Develop/Author is the > same thing. > >
I have no idea, I am only pushing buttons when it comes to dzil and sometimes they work. Maybe I just need to call dzil with some other flag to get those installed?
Subject: Re: [rt.cpan.org #133699] could not run dzil test on cloned repo
Date: Sun, 8 Nov 2020 00:28:30 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
On Sun, Nov 8, 2020 at 12:11 AM Diab Jerius via RT < bug-Alien-XPA@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=133699 > > > On Sat Nov 07 17:10:51 2020, DJERIUS wrote:
> > On Sat Nov 07 17:05:08 2020, gabor@szabgab.com wrote:
> > > > Ahh. Thanks, that would be most helpful. I'm having a devil of a > > > > time > > > > trying to figure out what exactly is causing build/test failures on > > > > CPAN > > > > for what seem to be almost identical platforms.
> > > > > > > > > Something seems to also require Sort::Versions, but I have not > > > understood > > > yet what because I don't see it anywhere in the repo.
> > > > > > That's bizarre; the dependency tree from CPAN doesn't show that (but > > doesn't seem to go that deep): > > > > https://cpandeps.grinnz.com/?dist=Alien- > > XPA&dist_version=&phase=test&perl_version=v5.30.2&style=auto
> > > Oh, wait; do you mean the dzil dependencies? > >
I don't know where I saw this Sort::Versions requirement, but it is now gone.
On Sat Nov 07 17:20:31 2020, gabor@szabgab.com wrote: Show quoted text
> On Sun, Nov 8, 2020 at 12:17 AM Diab Jerius via RT < > bug-Alien-XPA@rt.cpan.org> wrote: >
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=133699 > > > > > On Sat Nov 07 16:46:53 2020, DJERIUS wrote:
> > > On Sat Nov 07 16:39:12 2020, ETHER wrote:
> > > > On 2020-11-07 13:08:39, gabor@szabgab.com wrote: > > > >
> > > > > I wonder, is there a dzil command I should run to install all of > > > > > these > > > > > dependencies?
> > > > > > > > dist.ini needs to contain the lines: > > > > > > > > ; authordeps Pod::Weaver::Section::BugsAndLimitations > > > > ; authordeps Pod::Weaver::Section::SeeAlso > > > > > > > > ... and then you can install everything with 'dzil authordeps > > > > --missing | cpanm; dzil listdeps --missing | cpanm'.
> > > > > > > > > You know, I always forget the Pod::Weaver ones. Thanks !
> > > > Hmm. I have them listed under [Prereqs / DevelopRequires]. Shouldn't that > > automatically label them as authordeps? In my mind Develop/Author is the > > same thing. > > > >
> I have no idea, I am only pushing buttons when it comes to dzil and > sometimes they work.
Understood. I'm slightly less ignorant than when I started to use it, but I still sometimes treat it as a black box. Show quoted text
> > Maybe I just need to call dzil with some other flag to get those installed?
(I was replying to ether, so not trying to put you on the spot.) Upon further diving into dzil, it seems Prereqs are related to the distribution metadata and authordeps are related to dzil. I thought they (at least Prereqs/DeveloperRequires) were synonomus. I'll tweak the repo so that it'll behave more properly, and update this ticket when I do so.
Subject: Re: [rt.cpan.org #133699] could not run dzil test on cloned repo
Date: Sun, 8 Nov 2020 00:41:14 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
On Sun, Nov 8, 2020 at 12:33 AM Diab Jerius via RT < bug-Alien-XPA@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=133699 > > > On Sat Nov 07 17:20:31 2020, gabor@szabgab.com wrote:
> > On Sun, Nov 8, 2020 at 12:17 AM Diab Jerius via RT < > > bug-Alien-XPA@rt.cpan.org> wrote: > >
> > > <URL: https://rt.cpan.org/Ticket/Display.html?id=133699 > > > > > > > On Sat Nov 07 16:46:53 2020, DJERIUS wrote:
> > > > On Sat Nov 07 16:39:12 2020, ETHER wrote:
> > > > > On 2020-11-07 13:08:39, gabor@szabgab.com wrote: > > > > >
> > > > > > I wonder, is there a dzil command I should run to install all of > > > > > > these > > > > > > dependencies?
> > > > > > > > > > dist.ini needs to contain the lines: > > > > > > > > > > ; authordeps Pod::Weaver::Section::BugsAndLimitations > > > > > ; authordeps Pod::Weaver::Section::SeeAlso > > > > > > > > > > ... and then you can install everything with 'dzil authordeps > > > > > --missing | cpanm; dzil listdeps --missing | cpanm'.
> > > > > > > > > > > > You know, I always forget the Pod::Weaver ones. Thanks !
> > > > > > Hmm. I have them listed under [Prereqs / DevelopRequires]. Shouldn't
> that
> > > automatically label them as authordeps? In my mind Develop/Author is
> the
> > > same thing. > > > > > >
> > I have no idea, I am only pushing buttons when it comes to dzil and > > sometimes they work.
> > Understood. I'm slightly less ignorant than when I started to use it, but > I still sometimes treat it as a black box. >
> > > > Maybe I just need to call dzil with some other flag to get those
> installed? > > (I was replying to ether, so not trying to put you on the spot.) > > Upon further diving into dzil, it seems Prereqs are related to the > distribution metadata and authordeps are related to dzil. I thought they > (at least Prereqs/DeveloperRequires) were synonomus. > > I'll tweak the repo so that it'll behave more properly, and update this > ticket when I do so. >
Sure. In the meantime I managed to convince the CI to pass all the tests and sent you a Merge Request with it. It contains the "manual" installation of some of the Dzil modules. These can be later removed once they are pulled in to dist.ini Later I can try to add running CI on other platforms as well, but I hope this already can help a bit.
Subject: Re: [rt.cpan.org #133699] could not run dzil test on cloned repo
Date: Sun, 8 Nov 2020 09:36:48 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
On Sun, Nov 8, 2020 at 12:33 AM Diab Jerius via RT < bug-Alien-XPA@rt.cpan.org> wrote: Show quoted text
> > Maybe I just need to call dzil with some other flag to get those
> installed? > > (I was replying to ether, so not trying to put you on the spot.) >
Oh, I did not realize Ether was also in this conversation. You see, Gmail, where I read the whole thing, did not display the From properly. It showed the message coming from bug-Alien-XPA. So your comment about responding to ether further confused me. Now that I fetched the whole conversation to my computer and used alpine to look at the conversations I see the message that came from Karen. It makes more sense now :) Gabor
On Sat Nov 07 17:05:08 2020, gabor@szabgab.com wrote: Show quoted text
> > Ahh. Thanks, that would be most helpful. I'm having a devil of a time > > trying to figure out what exactly is causing build/test failures on CPAN > > for what seem to be almost identical platforms.
> > > Something seems to also require Sort::Versions, but I have not understood > yet what because I don't see it anywhere in the repo.
See https://github.com/PerlAlien/Alien-Build/issues/242
On Sat Nov 07 17:33:35 2020, DJERIUS wrote: Show quoted text
> On Sat Nov 07 17:20:31 2020, gabor@szabgab.com wrote:
> > On Sun, Nov 8, 2020 at 12:17 AM Diab Jerius via RT < > > bug-Alien-XPA@rt.cpan.org> wrote: > >
> > > <URL: https://rt.cpan.org/Ticket/Display.html?id=133699 > > > > > > > On Sat Nov 07 16:46:53 2020, DJERIUS wrote:
> > > > On Sat Nov 07 16:39:12 2020, ETHER wrote:
> > > > > On 2020-11-07 13:08:39, gabor@szabgab.com wrote: > > > > >
> > > > > > I wonder, is there a dzil command I should run to install all > > > > > > of > > > > > > these > > > > > > dependencies?
> > > > > > > > > > dist.ini needs to contain the lines: > > > > > > > > > > ; authordeps Pod::Weaver::Section::BugsAndLimitations > > > > > ; authordeps Pod::Weaver::Section::SeeAlso > > > > > > > > > > ... and then you can install everything with 'dzil authordeps > > > > > --missing | cpanm; dzil listdeps --missing | cpanm'.
> > > > > > > > > > > > You know, I always forget the Pod::Weaver ones. Thanks !
> > > > > > Hmm. I have them listed under [Prereqs / DevelopRequires]. > > > Shouldn't that > > > automatically label them as authordeps? In my mind Develop/Author > > > is the > > > same thing. > > > > > >
> > I have no idea, I am only pushing buttons when it comes to dzil and > > sometimes they work.
> > Understood. I'm slightly less ignorant than when I started to use it, > but I still sometimes treat it as a black box. >
> > > > Maybe I just need to call dzil with some other flag to get those > > installed?
> > (I was replying to ether, so not trying to put you on the spot.) > > Upon further diving into dzil, it seems Prereqs are related to the > distribution metadata and authordeps are related to dzil. I thought > they (at least Prereqs/DeveloperRequires) were synonomus. > > I'll tweak the repo so that it'll behave more properly, and update > this ticket when I do so.
I've updated the repo and added a CONTRIBUTING.md file which hopefully provides full instructions for building from the repo.
Subject: Re: [rt.cpan.org #133699] could not run dzil test on cloned repo
Date: Sat, 14 Nov 2020 10:16:51 +0200
To: bug-Alien-XPA [...] rt.cpan.org
From: Gabor Szabo <gabor [...] szabgab.com>
On Sat, Nov 14, 2020 at 7:32 AM Diab Jerius via RT < bug-Alien-XPA@rt.cpan.org> wrote: Show quoted text
> > I've updated the repo and added a CONTRIBUTING.md file which hopefully > provides full instructions for building from the repo. > >
Thanks. Having 4 spaces indentation in the md file will make the text verbatim. I think that was your intention with the command examples. I tried to do this in the templates/CONTRIBUTING.md and then I managed to use dzil regenerate to create the CONTRIBUTING.md once, but not any more, so I could not finish a PR for you with this. Also GitHub is mentioned several times in the CONTRIBUTING.md and I think you meant GitLab all the way.