Skip Menu |

This queue is for tickets about the CPANPLUS CPAN distribution.

Report information
The Basics
Id: 13368
Status: resolved
Priority: 0/
Queue: CPANPLUS

People
Owner: Nobody in particular
Requestors: rrwo [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.055
Fixed in: (no value)



Subject: CPANPLUS thinks a test passed when it failed
[MSG] Trying to get 'ftp://cpan.etla.org/pub/CPAN/authors/id/A/AW/AWRIGLEY/App-C ontrol-1.02.tar.gz' [MSG] Trying to get 'ftp://cpan.etla.org/pub/CPAN/authors/id/A/AW/AWRIGLEY/CHECK SUMS' [MSG] Checksum matches for 'App-Control-1.02.tar.gz' [MSG] Extracted 'App-Control-1.02/' [MSG] Extracted 'App-Control-1.02/README' [MSG] Extracted 'App-Control-1.02/Makefile.PL' [MSG] Extracted 'App-Control-1.02/Changes' [MSG] Extracted 'App-Control-1.02/sample/' [MSG] Extracted 'App-Control-1.02/sample/test.pl' [MSG] Extracted 'App-Control-1.02/MANIFEST' [MSG] Extracted 'App-Control-1.02/test.pl' [MSG] Extracted 'App-Control-1.02/Control.pm' [MSG] Extracted 'App::Control' to 'C:\perl5\.cpanplus\5.8.7\build\App-Control-1. 02' ==> MISSING Signature file! <== Running [C:\perl5\5.8.7\bin\MSWin32-x86-multi-thread\perl.exe Makefile.PL ]... Checking if your kit is complete... Looks good Writing Makefile for App::Control Running [C:\perl5\5.8.7\bin\MSWin32-x86-multi-thread\nmake.exe]... cp Control.pm blib\lib\App\Control.pm Microsoft (R) Program Maintenance Utility Version 1.50 Copyright (c) Microsoft Corp 1988-94. All rights reserved. Running [C:\perl5\5.8.7\bin\MSWin32-x86-multi-thread\nmake.exe test]... C:\perl5\5.8.7\bin\MSWin32-x86-multi-thread\perl.exe "-Iblib\lib" "-Ibli b\arch" test.pl 1..2 ok 1 not ok 2 Microsoft (R) Program Maintenance Utility Version 1.50 Copyright (c) Microsoft Corp 1988-94. All rights reserved. Creating new App::Control object sample/test.pl is not executable [MSG] MAKE TEST passed: C:\perl5\5.8.7\bin\MSWin32-x86-multi-thread\perl.exe "-Iblib\lib" "-Iblib\arch" test.pl 1..2 ok 1 not ok 2 Microsoft (R) Program Maintenance Utility Version 1.50 Copyright (c) Microsoft Corp 1988-94. All rights reserved. Creating new App::Control object sample/test.pl is not executable [MSG] Successfully sent 'pass' report for 'App-Control-1.02'
Robert, [guest - Wed Jun 22 11:33:07 2005]: [...] Show quoted text
> Running [C:\perl5\5.8.7\bin\MSWin32-x86-multi-thread\nmake.exe > test]... > C:\perl5\5.8.7\bin\MSWin32-x86-multi-thread\perl.exe "- > Iblib\lib" "-Ibli > b\arch" test.pl > 1..2 > ok 1 > not ok 2
[...] Show quoted text
> [MSG] Successfully sent 'pass' report for 'App-Control-1.02'
The problem with this distribution, and perhaps many others, is that they do neither use the Test.pm/Test::More framework, nor do they manually change the exit codes from their program based on whether it did it's job succesfully or not. Since the only way we have to know if a command completed succesfully, we can not tell whether the test ever failed, as the only feed back the author ever gives is visual, and not anything machine readable like an exit code: [kane@myriad ~...build/App-Control-1.02]$ perlc Makefile.PL; make test; echo $? Writing Makefile for App::Control PERL_DL_NONLAZY=1 /usr/bin/perlc "-Iblib/lib" "-Iblib/arch" test.pl 1..2 ok 1 [...] not ok 2 0 So i suggest you report this as a bug to the author of App::Control, so that his test suite may actually convey the information people desire from it.