Bug #133587 for Tk-TableMatrix: Compile error

Wed Oct 21 09:09:44 2020 HMBRAND [...] cpan.org - Ticket created

Subject:

Compile error

``` cc -c -I/pro/lib/perl5/site_perl/5.28.0/x86_64-linux-thread-multi-ld/Tk -I/pro/lib/perl5/site_perl/5.28.0/x86_64-linux-thread-multi-ld/Tk/pTk -I. -Ibitmaps -I/usr/include/freetype2 -D_REENTRANT -D_GNU_SOURCE -fPIC -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/pro/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -DVERSION=\"1.25\" -DXS_VERSION=\"0.9\" -fPIC "-I/pro/lib/perl5/5.28.0/x86_64-linux-thread-multi-ld/CORE" -Wall -Wno-implicit-int -Wno-comment -Wno-unused -D__USE_FIXED_PROTOTYPES__ tkAppInit.c tkAppInit.c: In function ‘Tcl_AppInit’: tkAppInit.c:116:56: error: ‘Tktable_SafeInit’ undeclared (first use in this function); did you mean ‘Tktable_Init’? Tcl_StaticPackage(interp, "Tktable", Tktable_Init, Tktable_SafeInit); ^~~~~~~~~~~~~~~~ Tktable_Init tkAppInit.c:116:56: note: each undeclared identifier is reported only once for each function it appears in ``` Linux 4.12.14-lp151.28.75-default [openSUSE Leap 15.1] This is perl 5, version 28, subversion 0 (v5.28.0) built for x86_64-linux-thread-multi-ld gcc (SUSE Linux) 7.5.0

Wed Oct 21 09:33:41 2020 HMBRAND [...] cpan.org - Correspondence added

Same here: Linux 5.8.14-1-default [openSUSE Tumbleweed 20201019] gcc (SUSE Linux) 10.2.1 20200825 This is perl 5, version 32, subversion 0 (v5.32.0) built for x86_64-linux-thread-multi-ld tk-devel-8.6.10-1.5.x86_64 cc -c -I/data/pro/lib/perl5/site_perl/5.32.0/x86_64-linux-thread-multi-ld/Tk -I/data/pro/lib/perl5/site_perl/5.32.0/x86_64-linux-thread-multi-ld/Tk/pTk -I. -Ibitmaps -I/usr/include/freetype2 -D_REENTRANT -D_GNU_SOURCE -fPIC -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/pro/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -DVERSION=\"1.25\" -DXS_VERSION=\"0.9\" -fPIC "-I/pro/lib/perl5/5.32.0/x86_64-linux-thread-multi-ld/CORE" tkAppInit.c tkAppInit.c: In function ‘Tcl_AppInit’: tkAppInit.c:116:56: error: ‘Tktable_SafeInit’ undeclared (first use in this function); did you mean ‘Tktable_Init’? 116 | Tcl_StaticPackage(interp, "Tktable", Tktable_Init, Tktable_SafeInit); | ^~~~~~~~~~~~~~~~ | Tktable_Init tkAppInit.c:116:56: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [Makefile:365: tkAppInit.o] Error 1

Wed Oct 21 09:34:01 2020 HMBRAND [...] cpan.org - Broken in 1.25 added

Thu Oct 22 18:38:12 2020 CAC [...] cpan.org - Correspondence added

I can reproduce this with macOS 10.15.7 and Perl 5.30.3. My impression is that certain files such as tkAppInit.c and tkTablePs.c were known to be broken (uncompilable) and so were excluded from build targets, even in upstream Tktable. Somehow these files are (now?) trying to get compiled anyway.

Thu Oct 22 18:38:13 2020 The RT System itself - Status changed from 'new' to 'open'

Fri Oct 23 12:48:45 2020 CAC [...] cpan.org - Correspondence added

I have not gotten to the bottom of this issue, but in part it is because Tk-TableMatrix 1.25 was packaged such that pTk/pTk.exc (and many other text files) use CRLF ("DOS") line endings, and is not chomped properly it on systems that use LF ("Unix") line endings.

Fri Oct 23 12:50:40 2020 CAC [...] cpan.org - Correspondence added

I meant pTk/mTk/Tktable/pTk.exc …

Fri Oct 23 19:34:48 2020 CAC [...] cpan.org - Correspondence added

I have committed a likely fix for this issue: https://github.com/asb-capfan/Tk-TableMatrix/commit/7f03179

Fri Oct 23 19:34:49 2020 CAC [...] cpan.org - Status changed from 'open' to 'patched'

Tue Oct 27 19:52:32 2020 CAC [...] cpan.org - Correspondence added

Seems fixed: CPAN testers only report PASS for 1.26.

Tue Oct 27 19:52:33 2020 CAC [...] cpan.org - Status changed from 'patched' to 'resolved'

Tue Oct 27 19:52:34 2020 CAC [...] cpan.org - Taken

Tue Oct 27 19:52:34 2020 CAC [...] cpan.org - Fixed in 1.26 added