Bug #133517 for Future-AsyncAwait: Test fails "SvPADMY" on -DDEBUGGING

Mon Oct 12 07:08:14 2020 leonerd-cpan [...] leonerd.org.uk - Ticket created

Subject:

Test fails "SvPADMY" on -DDEBUGGING

Debugging perls yield two possibly-related test failures: t/09await-cancel-block.t ........ perl5.20.3: inline.h:171: S_SvPADSTALE_off: Assertion `SvFLAGS(sv) & SVs_PADMY' failed. t/80await+dynamically.t ......... 1/? perl5.20.3: scope.c:1039: Perl_leave_scope: Assertion `SvPADMY(sv)' failed. -- Paul Evans

Thu Oct 22 11:57:50 2020 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Two separate bugs. The attached fixes one of them. -- Paul Evans

Subject:

rt133517-a1.patch

=== modified file 'lib/Future/AsyncAwait.xs' --- old/lib/Future/AsyncAwait.xs 2020-10-22 13:33:25 +0000 +++ new/lib/Future/AsyncAwait.xs 2020-10-22 15:52:07 +0000 @@ -1812,7 +1812,8 @@ PADOFFSET precancel_padix = PL_op->op_targ; if(precancel_padix) { - PAD_SVl(precancel_padix) = (SV *)newAV(); + SV *sv = PAD_SVl(precancel_padix) = (SV *)newAV(); + SvPADMY_on(sv); save_clearsv(&PAD_SVl(precancel_padix)); }

Thu Oct 22 12:19:50 2020 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Second was caused by a stale unit test; copying the updated one out of Syntax-Keyword-Dynamically fixes that. -- Paul Evans

Thu Oct 22 12:24:27 2020 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'

Sun Nov 01 12:19:08 2020 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Sun Nov 01 12:19:08 2020 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.45 added