Bug #133412 for Crypt-DES: FW: Crypt::DES cpan module

Diffs that I sent to Dave, re: Crypt::Des, see below. Thanks. From: David Stevenson <dstevenson@uplandsoftware.com> Date: Sunday, 20 September 2020 at 18:21 To: Dave Paris <dparis@w3works.com> Subject: Re: Crypt::DES cpan module Hi, The minimum change is this: $ diff -r patched original diff -r patched/Crypt-DES-2.07/DES.xs original/Crypt-DES-2.07/DES.xs 27d26 < #pragma clang diagnostic ignored "-Wimplicit-function-declaration" This pragma turns off the error for Clang and is safe for all versions of Clang, and, of course, being a comment should be safe for other compilers too! It doesn’t need any version checking ifdefs, in my view. I did consider the alternative, which is to define the prototypes for perl_des_expand_key and perl_des_crypt in _des.h, however that raised a different issue of “char *” versus “unsigned char *” pointers, and fixing that would be beyond the scope of this change, in my view. And it’s probably good to avoid actual code changes for code such as this, that has been stable for so long. Kind regards David PS The original issue was this: perl Makefile.PL && make Checking if your kit is complete... Looks good Writing Makefile for Crypt::DES Writing MYMETA.yml and MYMETA.json cp DES.pm blib/lib/Crypt/DES.pm /Users/dstevenson/.plenv/shims/perl /System/Library/Perl/5.18/ExtUtils/xsubpp -typemap /System/Library/Perl/5.18/ExtUtils/typemap -typemap typemap DES.xs > DES.xsc && mv DES.xsc DES.c cc -c -g -pipe -fno-common -DPERL_DARWIN -fno-strict-aliasing -fstack-protector -Os -DVERSION=\"2.07\" -DXS_VERSION=\"2.07\" -iwithsysroot "/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE" DES.c DES.xs:39:3: error: implicit declaration of function 'perl_des_expand_key' is invalid in C99 [-Werror,-Wimplicit-function-declaration] perl_des_expand_key((i8 *)key, ks); ^ DES.xs:39:3: note: did you mean '_des_expand_key'? ./_des.h:6:6: note: '_des_expand_key' declared here void _des_expand_key( des_user_key userKey, des_ks key ); ^ DES.xs:69:3: error: implicit declaration of function 'perl_des_crypt' is invalid in C99 [-Werror,-Wimplicit-function-declaration] perl_des_crypt(input, SvGROW(output, output_len), (i32 *)ks, enc_flag); ^ 2 errors generated. make: *** [DES.o] Error 1 From: Dave Paris <dparis@w3works.com> Date: Saturday, 19 September 2020 at 18:03 To: David Stevenson <dstevenson@uplandsoftware.com> Subject: Re: Crypt::DES cpan module HI David, Yep, I'm still maintaining Crypt::DES, Crypt:::Blowfish, etc. :) It's maintained on CPAN only, primarily because the crypto algorithms must be exact for the cryptography to be valid against tests. Diffs are happily accepted and typically updated within 72 hours of local testing completion. If you'd like to alter a definition specific for MacOS 10.5, you can do it within an if/else block. Thank you and kindest regards, Dave [Image removed by sender.]<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.avast.com%2Fsig-email%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Dwebmail%26utm_term%3Dicon&data=02%7C01%7Cdstevenson%40uplandsoftware.com%7C1118e80b44d14348863708d85cbde0b5%7Cdd02d1e4d2a8462892c81f4b5de6419b%7C0%7C1%7C637361317874801997&sdata=u93GHKYmp3PqV89AGwYJaB8kXq1Q100oth1X8vmJnS8%3D&reserved=0> Virus-free. www.avast.com<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.avast.com%2Fsig-email%3Futm_medium%3Demail%26utm_source%3Dlink%26utm_campaign%3Dsig-email%26utm_content%3Dwebmail%26utm_term%3Dlink&data=02%7C01%7Cdstevenson%40uplandsoftware.com%7C1118e80b44d14348863708d85cbde0b5%7Cdd02d1e4d2a8462892c81f4b5de6419b%7C0%7C1%7C637361317874801997&sdata=cLp6ZyZd415bBpI8i8b1IKB0OEYBE%2FFMpxNNOhnSVmw%3D&reserved=0> On Fri, Sep 18, 2020 at 7:00 PM David Stevenson <dstevenson@uplandsoftware.com<mailto:dstevenson@uplandsoftware.com>> wrote: Hi Dave, I’ve submitted an RT issue for Crypt::DES, for which MetaCPAN lists you as the maintainer. Are you still maintaining it? If so, I’ll be happy to provide a PR, but I couldn’t find a source repo on github, other than the read-only gitpan thing. If you aren’t interested in maintaining it, I might be able to apply to adopt it. What do you think? The issue is at https://rt.cpan.org/Public/Bug/Display.html?id=133363<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frt.cpan.org%2FPublic%2FBug%2FDisplay.html%3Fid%3D133363&data=02%7C01%7Cdstevenson%40uplandsoftware.com%7C1118e80b44d14348863708d85cbde0b5%7Cdd02d1e4d2a8462892c81f4b5de6419b%7C0%7C1%7C637361317874811993&sdata=nkUAQA5GszDDNPdu2s214NbcFfiYULc2EXD4%2FdMSIsg%3D&reserved=0> Regards, David.