Bug #133363 for Crypt-DES: Crypt::DES fails to build with Xcode 12

Fri Sep 18 17:54:06 2020 dstevenson [...] uplandsoftware.com - Ticket created

Subject:	Crypt::DES fails to build with Xcode 12
Date:	Fri, 18 Sep 2020 21:53:25 +0000
To:	"bug-Crypt-DES [...] rt.cpan.org" <bug-Crypt-DES [...] rt.cpan.org>
From:	David Stevenson <dstevenson [...] uplandsoftware.com>

Apple clang in Xcode 12 (now beta) sets "-Werror=implicit-function-declaration" by default, so it causes an error compiling the C that is generated from DES.xs cc -c -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -DPERL_USE_SAFE_PUTENV -O3 -DVERSION=\"2.07\" -DXS_VERSION=\"2.07\" "-I/Users/davids/.plenv/versions/5.32.0/lib/perl5/5.32.0/darwin-2level/CORE" DES.c DES.xs:39:3: error: implicit declaration of function 'perl_des_expand_key' is invalid in C99 [-Werror,-Wimplicit-function-declaration] perl_des_expand_key((i8 *)key, ks); ^ With previous releases, and other compilers, it was “just” a warning. I’m happy to provide a PR to fix it if anyone is maintaining this module. Regards David

Thu Sep 24 09:01:53 2020 fraserbn [...] gmail.com - Correspondence added

On Fri Sep 18 17:54:06 2020, dstevenson@uplandsoftware.com wrote: Show quoted text

> Apple clang in Xcode 12 (now beta) sets "-Werror=implicit-function- > declaration" by default, > so it causes an error compiling the C that is generated from DES.xs > > cc -c -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -fno- > strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include > -DPERL_USE_SAFE_PUTENV -O3 -DVERSION=\"2.07\" -DXS_VERSION=\"2.07\" > "-I/Users/davids/.plenv/versions/5.32.0/lib/perl5/5.32.0/darwin- > 2level/CORE" DES.c > DES.xs:39:3: error: implicit declaration of function > 'perl_des_expand_key' is invalid in C99 [-Werror,-Wimplicit-function- > declaration] > perl_des_expand_key((i8 *)key, ks); > ^ > > With previous releases, and other compilers, it was “just” a warning. > > I’m happy to provide a PR to fix it if anyone is maintaining this > module. > > Regards > David > > >

Just ran into the same thing myself -- attached is a patch to address it, though I too don't know if Dave is still maintaining this distribution.

Subject:

0001-_des.h-expose-perl_des_expand_key-and-perl_des_crypt.patch

From 51fda02d223f516c4948606c050bfc732b95f481 Mon Sep 17 00:00:00 2001 From: Brian Fraser <brian.fraser@booking.com> Date: Thu, 24 Sep 2020 15:00:20 +0200 Subject: [PATCH] _des.h: expose perl_des_expand_key() and perl_des_crypt() to prevent implicit delaration errors/warnings --- _des.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/_des.h b/_des.h index ec56b27..b636cda 100644 --- a/_des.h +++ b/_des.h @@ -4,4 +4,6 @@ typedef unsigned long des_ks[32]; void _des_crypt( des_cblock in, des_cblock out, des_ks key, int encrypt ); void _des_expand_key( des_user_key userKey, des_ks key ); +void perl_des_expand_key(des_user_key userKey, des_ks ks); +void perl_des_crypt( des_cblock input, des_cblock output, des_ks ks, int encrypt ); -- 2.24.3 (Apple Git-128)

Thu Sep 24 09:01:54 2020 The RT System itself - Status changed from 'new' to 'open'

Thu Sep 24 09:35:37 2020 dstevenson [...] uplandsoftware.com - Correspondence added

Subject:	Re: [rt.cpan.org #133363] Crypt::DES fails to build with Xcode 12
Date:	Thu, 24 Sep 2020 13:35:04 +0000
To:	"bug-Crypt-DES [...] rt.cpan.org" <bug-Crypt-DES [...] rt.cpan.org>
From:	David Stevenson <dstevenson [...] uplandsoftware.com>

Hi, I spoke to Dave, he said he's still maintaining it, asked for a 'diff' which I sent him on Sunday. All I did was turn off the error. Adding the missing function prototypes produced other warnings about converting between char * and unsigned char *, so I felt that fixing it properly was beyond the scope of what I was trying to remedy here. I'll forward you the diffs I sent him. Regards David On 24/09/2020, 14:01, "Brian Fraser via RT" <bug-Crypt-DES@rt.cpan.org> wrote: <URL: https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frt.cpan.org%2FTicket%2FDisplay.html%3Fid%3D133363&data=02%7C01%7Cdstevenson%40uplandsoftware.com%7Cb5d89525aed8405371ef08d8608a0340%7Cdd02d1e4d2a8462892c81f4b5de6419b%7C0%7C1%7C637365493188622719&sdata=4lKMYeqn0cSECj9zv5j44rP5zN%2Bkn%2F5LSTRJ59JHLRo%3D&reserved=0 > On Fri Sep 18 17:54:06 2020, dstevenson@uplandsoftware.com wrote: Show quoted text

> Apple clang in Xcode 12 (now beta) sets "-Werror=implicit-function- > declaration" by default, > so it causes an error compiling the C that is generated from DES.xs > > cc -c -fno-common -DPERL_DARWIN -mmacosx-version-min=10.15 -fno- > strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include > -DPERL_USE_SAFE_PUTENV -O3 -DVERSION=\"2.07\" -DXS_VERSION=\"2.07\" > "-I/Users/davids/.plenv/versions/5.32.0/lib/perl5/5.32.0/darwin- > 2level/CORE" DES.c > DES.xs:39:3: error: implicit declaration of function > 'perl_des_expand_key' is invalid in C99 [-Werror,-Wimplicit-function- > declaration] > perl_des_expand_key((i8 *)key, ks); > ^ > > With previous releases, and other compilers, it was “just” a warning. > > I’m happy to provide a PR to fix it if anyone is maintaining this > module. > > Regards > David > > >

Just ran into the same thing myself -- attached is a patch to address it, though I too don't know if Dave is still maintaining this distribution.