Bug #133322 for IO-Socket-IP: IO::Socket::IP is not strict.

Sat Sep 12 23:58:14 2020 TODDR [...] cpan.org - Ticket created

Subject:

IO::Socket::IP is not strict.

$VERSION is not declared outside the BEGIN block with an our. I suggest: diff --git a/cpan/IO-Socket-IP/lib/IO/Socket/IP.pm b/cpan/IO-Socket-IP/lib/IO/Socket/IP.pm index 5a5ee7d204..10e63d1365 100644 --- a/cpan/IO-Socket-IP/lib/IO/Socket/IP.pm +++ b/cpan/IO-Socket-IP/lib/IO/Socket/IP.pm @@ -6,6 +6,7 @@ package IO::Socket::IP; # $VERSION needs to be set before use base 'IO::Socket' # - https://rt.cpan.org/Ticket/Display.html?id=92107 +our $VERSION; BEGIN { $VERSION = '0.39'; }

Tue Sep 15 11:36:16 2020 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Slightly nicer is to contain the `our` inside the BEGIN block so it doesn't lexically leak. Also, moved the `use strict+warnings` to the top to catch it or similar in future. -- Paul Evans

Subject:

rt133322.patch

=== modified file 'lib/IO/Socket/IP.pm' --- old/lib/IO/Socket/IP.pm 2017-06-20 15:08:50 +0000 +++ new/lib/IO/Socket/IP.pm 2020-09-15 15:35:19 +0000 @@ -4,14 +4,16 @@ # (C) Paul Evans, 2010-2015 -- leonerd@leonerd.org.uk package IO::Socket::IP; + +use strict; +use warnings; + # $VERSION needs to be set before use base 'IO::Socket' # - https://rt.cpan.org/Ticket/Display.html?id=92107 BEGIN { - $VERSION = '0.39'; + our $VERSION = '0.39'; } -use strict; -use warnings; use base qw( IO::Socket ); use Carp;

Tue Sep 15 11:36:16 2020 The RT System itself - Status changed from 'new' to 'open'

Tue Sep 15 11:36:16 2020 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'

Tue Sep 15 18:37:06 2020 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Fixed in 0.40 / 0.41 -- Paul Evans

Tue Sep 15 18:37:07 2020 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Tue Sep 15 18:37:07 2020 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.41 added