Skip Menu |

This queue is for tickets about the Pod-Checker CPAN distribution.

Report information
The Basics
Id: 133312
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: Pod-Checker

People
Owner: Marek.Rouchal [...] gmx.net
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 1.73
  • 1.60
  • 1.70
  • 1.71
  • 1.72
  • 1.72_01
Fixed in: 1.74



Subject: Add strict compliance to Pod-Checker
We're looking at cleaning up perl blead and noticed that a few files were not strict. Patch attached to fix it.
Subject: PC.patch.txt
diff --git a/cpan/Pod-Checker/scripts/podchecker.PL b/cpan/Pod-Checker/scripts/podchecker.PL index 44bcfc5c0a..02fd6a5d9b 100644 --- a/cpan/Pod-Checker/scripts/podchecker.PL +++ b/cpan/Pod-Checker/scripts/podchecker.PL @@ -1,5 +1,5 @@ #!/usr/local/bin/perl - +use strict; use Config; use File::Basename qw(&basename &dirname); use Cwd; @@ -13,6 +13,7 @@ use Cwd; # This forces PL files to create target in same directory as PL file. # This is so that make depend always knows where to find PL derivatives. +my ($origdir, $file); $origdir = cwd; chdir(dirname($0)); ($file = basename($0)) =~ s/\.PL$//; diff --git a/cpan/Pod-Checker/t/pod/testpchk.pl b/cpan/Pod-Checker/t/pod/testpchk.pl index 8517cbdd95..36eec48fe6 100644 --- a/cpan/Pod-Checker/t/pod/testpchk.pl +++ b/cpan/Pod-Checker/t/pod/testpchk.pl @@ -1,8 +1,10 @@ package TestPodChecker; +use strict; +use File::Basename; +use File::Spec; + BEGIN { - use File::Basename; - use File::Spec; push @INC, '..'; my $THISDIR = dirname $0; unshift @INC, $THISDIR; @@ -14,7 +16,7 @@ BEGIN { } use Pod::Checker; -use vars qw(@ISA @EXPORT $MYPKG); +use vars qw(@ISA @EXPORT @EXPORT_OK $MYPKG); #use strict; #use diagnostics; use Carp;