Skip Menu |

This queue is for tickets about the autodie CPAN distribution.

Report information
The Basics
Id: 133192
Status: rejected
Priority: 0/
Queue: autodie

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc: TODDR [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.32
Fixed in: (no value)



CC: TODDR [...] cpan.org
Subject: t/version_tag.t: "Expanding :0.001 should succeed" fails
Today, I updated my fork of https://github.com/pjf/autodie and attempted to build and test what appears to be autodie-2.32. (I say "appears" because $VERSION inside the generated Makefile.PL is '0.001'.) After installing all prerequisites specified by Dist::Zilla, I was able to call 'dzil build', which in turn generated a subdirectory with a Makefile.PL. From there: ##### $ perl Makefile.PL && make && make test Checking if your kit is complete... Looks good Generating a Unix-style Makefile Writing Makefile for autodie Writing MYMETA.yml and MYMETA.json cp lib/Fatal.pm blib/lib/Fatal.pm ... cp lib/autodie/exception.pm blib/lib/autodie/exception.pm Manifying 9 pod documents PERL_DL_NONLAZY=1 "/home/jkeenan/perl5/perlbrew/perls/perl-5.32.0/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-load.t ...................... ok t/args.t ......................... ok ... t/version.t ...................... skipped: Release test. Set $ENV{RELEASE_TESTING} to true to run. t/version_tag.t .................. 1/10 # Failed test 'Expanding :0.001 should succeed' # at t/version_tag.t line 31. # got: 'Invalid exception class :0.001 at t/version_tag.t line 29. # eval {...} called at t/version_tag.t line 29 # ' # expected: '' # Looks like you failed 1 test of 10. t/version_tag.t .................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/10 subtests Test Summary Report ------------------- t/version_tag.t (Wstat: 256 Tests: 10 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=65, Tests=515, 5 wallclock secs ( 0.18 usr 0.07 sys + 3.87 cusr 0.54 csys = 4.66 CPU) Result: FAIL Failed 1/65 test programs. 1/515 subtests failed. Makefile:928: recipe for target 'test_dynamic' failed make: *** [test_dynamic] Error 1 ##### Here is the output of 'prove': ##### [autodie-0.001] 759 $ prove -vb t/version_tag.t t/version_tag.t .. 1..10 ok 1 - 'Basic version tags work' isa 'autodie::exception' ok 2 - Expanding :1.00 should fail not ok 3 - Expanding :0.001 should succeed # Failed test 'Expanding :0.001 should succeed' # at t/version_tag.t line 31. # got: 'Invalid exception class :0.001 at t/version_tag.t line 29. # eval {...} called at t/version_tag.t line 29 # ' # expected: '' ok 4 - chmod wasn't supported in 2.07 ok 5 - 'Our current version supports chmod' isa 'autodie::exception' ok 6 - chown wasn't supported in 2.13 ok 7 - 'Our current version supports chown' isa 'autodie::exception' ok 8 - utime is not autodying outside of any autodie context. ok 9 - utime wasn't supported in 2.13 ok 10 - 'Our current version supports utime' isa 'autodie::exception' # Looks like you failed 1 test of 10. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/10 subtests Test Summary Report ------------------- t/version_tag.t (Wstat: 256 Tests: 10 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=1, Tests=10, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.07 cusr 0.00 csys = 0.09 CPU) Result: FAIL ##### This is perl-5.32.0 on an unthreaded build on Linux. Note: I got the same error when I configured with a "Perl 7-ish" perl executable in which 'strict-by-defaults' is implemented. Thank you very much. Jim Keenan
That's because dzil build bumps the version and lib/Fatal.pm has to be manually updated every version. It's super annoying but not enough for me to have fixed it. I'm happy for a patch if you like.
Subject: Re: [rt.cpan.org #133192] t/version_tag.t: "Expanding :0.001 should succeed" fails
Date: Wed, 19 Aug 2020 20:01:12 -0400
To: bug-autodie [...] rt.cpan.org, jkeenan [...] cpan.org
From: James E Keenan <jkeenan [...] pobox.com>
On 8/19/20 5:56 PM, Todd Rinaldo via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=133192 > > > That's because dzil build bumps the version and lib/Fatal.pm has to be manually updated every version. It's super annoying but not enough for me to have fixed it. I'm happy for a patch if you like. >
As long as it doesn't affect the version of autodie.pm that ships with core (either p5 or 07) and its tests, I don't care. I simply came across it in the course of checking the p7-ness of the CPAN distro. (And this is another reason why I hate Dist::Zilla. It leads me to file unnecessary bug reports!) You can close this ticket. Thanks for quick response.
We've determined not to fix this for now.