Bug #133161 for Perl-Tidy: [cpan-questions #36650] perltidy -html does not work for pod with the latest version.,

Fri Aug 14 20:31:24 2020 perlsky [...] gmail.com - Ticket created

Subject:

[cpan-questions #36650] perltidy -html does not work for pod with the latest version.,

I faced with the following error by -html option. Undefined subroutine &Perl::Tidy::HtmlWriter::pod2html called at /usr/local/share/perl/5.30.0/Perl/Tidy/HtmlWriter.pm line 716. Perl-Tidy-20170521.tar.gz has produced a perfect html document. Please fix this degradation.

Fri Aug 14 21:12:16 2020 perltidy [...] users.sourceforge.net - Correspondence added

Thanks for the report. The error was introduced in a coding change in which a 'require' should have been a 'use'. The needed correction is as follows: Change line 36 of lib/Perl/Tidy/HtmlWriter.pm from: if ( !eval { require Pod::Html; 1 } ) { To be: if ( !eval { use Pod::Html; 1 } ) { This will be fixed in the next version.

Fri Aug 14 21:12:17 2020 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 14 21:28:04 2020 haarg [...] haarg.org - Correspondence added

On Fri Aug 14 21:12:16 2020, SHANCOCK wrote: Show quoted text

> Thanks for the report. The error was introduced in a coding change in > which a 'require' should have been a 'use'. > The needed correction is as follows: > > Change line 36 of lib/Perl/Tidy/HtmlWriter.pm from: > > if ( !eval { require Pod::Html; 1 } ) { > > To be: > > if ( !eval { use Pod::Html; 1 } ) { > > This will be fixed in the next version.

use happens at compile time, so the eval won't have any impact at all. If the module is not available, the module will fail to compile. I haven't checked the rest of the code to confirm if that is a problem.

Fri Aug 14 22:37:36 2020 perltidy [...] users.sourceforge.net - Correspondence added

Thanks; so a better fix is to change line 716 from pod2html(@args); to Pod::Html::pod2html(@args);

Sat Aug 15 01:54:27 2020 perlsky [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #133161] [cpan-questions #36650] perltidy -html does not work for pod with the latest version.,
Date:	Sat, 15 Aug 2020 14:54:09 +0900
To:	bug-Perl-Tidy [...] rt.cpan.org
From:	Yutaka Mawake <perlsky [...] gmail.com>

I don’t know how to appreciate your effort for this immediate bug fix. I already verified That the final answer fixes this issue. Thank you very much. 2020年8月15日(土) 11:37 Steve Hancock via RT <bug-Perl-Tidy@rt.cpan.org>: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=133161 > > > Thanks; so a better fix is to change line 716 from > > pod2html(@args); > to > Pod::Html::pod2html(@args); >

-- Sent from Gmail Mobile

Sat Aug 22 10:07:08 2020 perltidy [...] users.sourceforge.net - Correspondence added

This is fixed in version 20200822. Thank you for the bug report.

Sat Aug 22 10:07:08 2020 perltidy [...] users.sourceforge.net - Status changed from 'open' to 'resolved'