Skip Menu |

This queue is for tickets about the Authen-PAM CPAN distribution.

Report information
The Basics
Id: 133120
Status: open
Priority: 0/
Queue: Authen-PAM
People
Owner: Nobody in particular
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.16
Fixed in: (no value)

History Show all quoted text
  Wed Aug 05 17:40:07 2020 TODDR [...] cpan.org - Ticket created
Subject: XS version logic fails with perl > 7.0.0
Hi, This module fails to build once the perl version goes from 5 to 7. Devel::PPPort now provides proper version comparison logic so you don't need to to roll your own. I am providing you with a patch to fix this. Hope that helps! Todd
  Wed Aug 05 17:41:21 2020 TODDR [...] cpan.org - Correspondence added
here you go.
Subject: Use-ppport.h-for-version-comparison-logic-in-XS.patch

Message body is not shown because it is too large.

  Wed Aug 05 19:59:50 2020 ether [...] cpan.org - Correspondence added
ppport.h shouldn't be included with the patch, as this implies it will never be upgraded again when Devel::PPPort increases. Instead, it should be generated in the normal way via Makefile.PL in author mode: if (!-f 'META.yml' or -d '.git') { require Devel::PPPort; Devel::PPPort->VERSION(3.58); Devel::PPPort::WriteFile(); }
  Wed Aug 05 19:59:50 2020 The RT System itself - Status changed from 'new' to 'open'
  Wed Aug 05 20:02:33 2020 ether [...] cpan.org - Correspondence added
On 2020-08-05 16:59:50, ETHER wrote: Show quoted text
> ppport.h shouldn't be included with the patch, as this implies it will > never be upgraded again when Devel::PPPort increases. Instead, it > should be generated in the normal way via Makefile.PL in author mode: > > if (!-f 'META.yml' or -d '.git') { > require Devel::PPPort; > Devel::PPPort->VERSION(3.58); > Devel::PPPort::WriteFile(); > }
This patch isn't correct either, since Devel::PPPort has not yet been released with the appropriate macros. Please wait until that occurs.