Bug #133119 for Bit-Vector: XS Version logic breaks if perl's major version

Wed Aug 05 17:18:46 2020 TODDR [...] cpan.org - Ticket created

Subject:

XS Version logic breaks if perl's major version > 5

Hi, This module fails to build once the perl version goes from 5 to 7. Devel::PPPort now provides proper version comparison logic so you don't need to to roll your own. I am providing you with a patch to fix this. Hope that helps! Todd

Wed Aug 05 17:20:53 2020 TODDR [...] cpan.org - Correspondence added

Here you go.

Subject:

Use-ppport.h-for-version-comparison-logic-in-XS.patch

Message body is not shown because it is too large.

Wed Aug 05 20:00:11 2020 ether [...] cpan.org - Correspondence added

ppport.h shouldn't be included with the patch, as this implies it will never be upgraded again when Devel::PPPort increases. Instead, it should be generated in the normal way via Makefile.PL in author mode: if (!-f 'META.yml' or -d '.git') { require Devel::PPPort; Devel::PPPort->VERSION(3.58); Devel::PPPort::WriteFile(); }

Wed Aug 05 20:00:11 2020 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 05 20:02:15 2020 ether [...] cpan.org - Correspondence added

On 2020-08-05 17:00:11, ETHER wrote: Show quoted text

> ppport.h shouldn't be included with the patch, as this implies it will > never be upgraded again when Devel::PPPort increases. Instead, it > should be generated in the normal way via Makefile.PL in author mode: > > if (!-f 'META.yml' or -d '.git') { > require Devel::PPPort; > Devel::PPPort->VERSION(3.58); > Devel::PPPort::WriteFile(); > }

This patch isn't correct either, since Devel::PPPort has not yet been released with the appropriate macros. Please wait until that occurs.

Bug #133119 for Bit-Vector: XS Version logic breaks if perl's major version > 5