| Subject: | t/Complex.t is testing some unexported functions: _stringify_cartesian and _stringify_polar |
when enabling strict and warnings we can notice these errors while doing the eval for all @script to test
```
===== t/Complex.t
1..1072
Scalar found where operator expected at (eval 4) line 701, near "_stringify_cartesian $z0"
(Do you need to predeclare _stringify_cartesian?)
Scalar found where operator expected at (eval 4) line 704, near "_stringify_cartesian $z0"
(Do you need to predeclare _stringify_cartesian?)
Scalar found where operator expected at (eval 4) line 707, near "_stringify_cartesian $z0"
(Do you need to predeclare _stringify_cartesian?)
Scalar found where operator expected at (eval 4) line 710, near "_stringify_cartesian $z0"
(Do you need to predeclare _stringify_cartesian?)
Scalar found where operator expected at (eval 4) line 713, near "_stringify_cartesian $z0"
(Do you need to predeclare _stringify_cartesian?)
Scalar found where operator expected at (eval 4) line 716, near "_stringify_cartesian $z0"
(Do you need to predeclare _stringify_cartesian?)
Scalar found where operator expected at (eval 4) line 719, near "_stringify_cartesian $z0"
(Do you need to predeclare _stringify_cartesian?)
Scalar found where operator expected at (eval 4) line 722, near "_stringify_polar $z0"
(Do you need to predeclare _stringify_polar?)
Scalar found where operator expected at (eval 4) line 725, near "_stringify_polar $z0"
(Do you need to predeclare _stringify_polar?)
Scalar found where operator expected at (eval 4) line 728, near "_stringify_polar $z0"
(Do you need to predeclare _stringify_polar?)
syntax error at (eval 4) line 701, near "_stringify_cartesian $z0"
syntax error at (eval 4) line 704, near "_stringify_cartesian $z0"
syntax error at (eval 4) line 707, near "_stringify_cartesian $z0"
syntax error at (eval 4) line 710, near "_stringify_cartesian $z0"
syntax error at (eval 4) line 713, near "_stringify_cartesian $z0"
syntax error at (eval 4) line 716, near "_stringify_cartesian $z0"
syntax error at (eval 4) line 719, near "_stringify_cartesian $z0"
syntax error at (eval 4) line 722, near "_stringify_polar $z0"
syntax error at (eval 4) line 725, near "_stringify_polar $z0"
syntax error at (eval 4) line 728, near "_stringify_polar $z0"
(eval 4) has too many errors.
status 255
```
This is coming from the fact that _stringify_cartesian and _stringify_polar are note available in main::
A simple patch is to setup some aliases for these two functions, view attached patch.
Thanks for considering this patch
| Subject: | 0001-fix-cpan-Math-Complex-t-Complex.t.patch |
From 8f9cd8af4575265149d3267e607a01ec1868622b Mon Sep 17 00:00:00 2001
From: Nicolas R <atoomic@cpan.org>
Date: Mon, 29 Jun 2020 10:13:51 -0600
Subject: [PATCH] fix cpan/Math-Complex/t/Complex.t
---
cpan/Math-Complex/t/Complex.t | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/cpan/Math-Complex/t/Complex.t b/cpan/Math-Complex/t/Complex.t
index 04a4d74420..c4fd96f8bd 100644
--- a/cpan/Math-Complex/t/Complex.t
+++ b/cpan/Math-Complex/t/Complex.t
@@ -11,6 +11,10 @@ use warnings;
use Math::Complex 1.54;
+# they are used later in the test and not exported by Math::Complex
+*_stringify_cartesian = \&Math::Complex::_stringify_cartesian;
+*_stringify_polar = \&Math::Complex::_stringify_polar;
+
our $vax_float = (pack("d",1) =~ /^[\x80\x10]\x40/);
our $has_inf = !$vax_float;
--
2.24.3 (Apple Git-128)