Bug #132654 for Mail-IMAPClient: [PATCH] avoid cyclic reference on ->compress

Mon May 18 17:22:10 2020 e [...] yhbt.net - Ticket created

Subject:	[PATCH] avoid cyclic reference on ->compress
Date:	Mon, 18 May 2020 21:12:56 +0000
To:	bug-Mail-IMAPClient [...] rt.cpan.org
From:	Eric Wong <e [...] yhbt.net>

Hello, I noticed enabling compression causes a memory leak. This leak gets bad with long-lived processes and flaky (mobile) connections requiring frequent reconnects. Attached is a small patch which fixes the issue. If you want, I can also provide a bigger patch which avoids anonymous subs in ->compress entirely. I find anonymous subs error-prone and a frequent source of mistakes like these which lead to memory leaks. Thanks for Mail::IMAPClient!

Message body is not shown because sender requested not to inline it.

Sun May 31 17:44:59 2020 PLOBBES [...] cpan.org - Taken

Mon Oct 12 00:34:14 2020 PLOBBES [...] cpan.org - Correspondence added

Thanks for the report. If you still want to share your larger patch to avoid the anonymous subs, I'd certainly be willing to take a look at it and see if it's worth trying to get into a future release!

Mon Oct 12 00:34:15 2020 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 13 00:15:51 2020 PLOBBES [...] cpan.org - Correspondence added

commit 0f8d7f9cd804083271228c37ce6f50945db21a5f (HEAD -> master, origin/master, origin/HEAD) Author: Phil Pearl <plobbes@gmail.com> Date: Tue Oct 13 00:14:25 2020 -0400 - rt.cpan.org#132654: avoid cyclic reference on ->compress

Tue Oct 13 00:15:52 2020 PLOBBES [...] cpan.org - Status changed from 'open' to 'patched'

Tue Oct 13 01:24:40 2020 e [...] yhbt.net - Correspondence added

CC:	DJKERNEN__NO_SOLICITING__ [...] cpan.org
Subject:	Re: [rt.cpan.org #132654] [PATCH] avoid cyclic reference on ->compress
Date:	Tue, 13 Oct 2020 05:17:28 +0000
To:	"Phil Pearl (Lobbes) via RT" <bug-Mail-IMAPClient [...] rt.cpan.org>
From:	Eric Wong <e [...] yhbt.net>

"Phil Pearl (Lobbes) via RT" <bug-Mail-IMAPClient@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=132654 > > > Thanks for the report. If you still want to share your larger patch to avoid the anonymous subs, I'd certainly be willing to take a look at it and see if it's worth trying to get into a future release!

You're welcome, Phil. Unfortunately, I never got around to working on the patch to avoid anonymous subs and will likely be busy with other stuff for the next few months. Maybe I'll cycle back to it next year or you can handle it in the meantime. Thanks again for this module!