Skip Menu |

This queue is for tickets about the Quiq CPAN distribution.

Report information
The Basics
Id: 132386
Status: resolved
Priority: 0/
Queue: Quiq
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.179
Fixed in: 1.180

History Show all quoted text
  Mon Apr 20 01:49:41 2020 SREZIC [...] cpan.org - Ticket created
Subject: t/bin/Quiq/DirHandle.t fails on CentOS 8
The test suite fails only on my CentOS 8 smoker --- other CentOS versions (6 and 7), Debian, Ubuntu, FreeBSD are OK. ... # Failed test at t/bin/Quiq/DirHandle.t line 28. # Looks like you failed 1 test of 2. t/bin/Quiq/DirHandle.t .......................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests ...
  Tue Apr 21 13:02:54 2020 FSEITZ [...] cpan.org - Correspondence added
On Mon Apr 20 01:49:41 2020, SREZIC wrote: Show quoted text
> The test suite fails only on my CentOS 8 smoker --- other CentOS > versions (6 and 7), Debian, Ubuntu, FreeBSD are OK. > > ... > # Failed test at t/bin/Quiq/DirHandle.t line 28. > # Looks like you failed 1 test of 2. > t/bin/Quiq/DirHandle.t .......................... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/2 subtests > ...
Hello Slaven, what is the result, when you change $self->ok(@arr > 2) to $self->ok(@arr >= 2) in t/bin/Quiq/DirHandle.t? Thank you very much Frank
  Tue Apr 21 13:02:55 2020 The RT System itself - Status changed from 'new' to 'open'
  Sun Apr 26 05:43:32 2020 FSEITZ [...] cpan.org - Correspondence added
Problem solved
  Sun Apr 26 05:43:33 2020 FSEITZ [...] cpan.org - Status changed from 'open' to 'resolved'
  Sun Apr 26 05:43:33 2020 FSEITZ [...] cpan.org - Fixed in 1.180 added
  Sun Apr 26 06:04:26 2020 SREZIC [...] cpan.org - Correspondence added
On 2020-04-26 05:43:32, FSEITZ wrote: Show quoted text
> Problem solved
I don't think the fix is correct. A file named "0" in /tmp may still cause problems --- I don't know if it's guaranteed that getdirentries() and readdir() always start with "." and ".." --- if it does not, and there's a "0" file, then there's again trouble. Best is to rewrite the loop in the test to use defined() instead of just checking for true/false: while (defined(my $entry = $dh->next)) {
  Sun Apr 26 06:23:20 2020 FSEITZ [...] cpan.org - Correspondence added
You're right. I extended the test code according to your proposal. Thank you!