| CC: | shay [...] cpan.org |
| Subject: | Replace hand-crafted test functions with Test::More equivalents |
| Date: | Sun, 12 Apr 2020 18:29:32 -0400 |
| To: | bug-libnet [...] rt.cpan.org |
| From: | James E Keenan <jkeenan [...] pobox.com> |
Four test files in this distribution use hand-crafted testing
subroutines found in t/libnet_t.pl. The four test files import these
functions via "require t/libnet_t.pl". Note the absence of "./" at the
start of the argument to require. That runs afoul of the no-dot-in-@INC
rule instituted in perl-5.28. This violation requires a special
work-around in the core distribution's t/TEST.
However, the testing subroutines in t/libnet_t.pl appear to date from
the very early days of Perl 5 when Test::More had not yet been written.
The Test::More functions are drop-in replacements for the t/libnet_t.pl
ones. Let's use them.
This enables us to eliminate t/libnet_t.pl from this distribution, so we
update the MANIFEST as well. See first patch attached. Application of
this patch will enable us to remove 'cpan/libnet' from the list of
distributions needing a workaround in the core's t/TEST.
Some small meta touchups in second patch attached.
Thank you very much.
Jim Keenan
Message body is not shown because sender requested not to inline it.
Message body is not shown because sender requested not to inline it.