Bug #132137 for Authen-TacacsPlus: File descriptor leak and documentation patch for release 0.27

Fri Mar 13 12:26:50 2020 hvn [...] open.com.au - Ticket created

Subject:	File descriptor leak and documentation patch for release 0.27
Date:	Fri, 13 Mar 2020 18:17:40 +0200
To:	bug-Authen-TacacsPlus [...] rt.cpan.org
From:	Heikki Vatiainen <hvn [...] open.com.au>

The attached patch fixes the following 3 issues in Authen-Tacacsplus release 0.27: - File descriptor leak introduced in release 0.25 where check for open connection was added to TacacsPlus::close() before calling tacpluslib's deinit_tac_session() - File descriptor leak in tacpluslib's init_tac_session where close() was not called for the newly created socket if, for example, destination host was unreachable - Port and Timeout TacacsPlus::new() parameters were documented incorrectly. The are not passed within array references. Thanks, Heikki -- Heikki Vatiainen <hvn@open.com.au>

Message body is not shown because sender requested not to inline it.

Fri Mar 13 20:44:51 2020 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #132137] File descriptor leak and documentation patch for release 0.27
Date:	Sat, 14 Mar 2020 10:24:33 +1000
To:	bug-Authen-TacacsPlus [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Thanks Heikki, New version 0.28 with your patch has been sent to CPAN. On Saturday, 14 March 2020 02:26:51 AEST Heikki Vatiainen via RT wrote: Show quoted text

> Fri Mar 13 12:26:50 2020: Request 132137 was acted upon. > Transaction: Ticket created by hvn@open.com.au > Queue: Authen-TacacsPlus > Subject: File descriptor leak and documentation patch for release 0.27 > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: hvn@open.com.au > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=132137 > > > > The attached patch fixes the following 3 issues in Authen-Tacacsplus > release 0.27: > > - File descriptor leak introduced in release 0.25 where check for open > connection was added to TacacsPlus::close() before calling tacpluslib's > deinit_tac_session() > - File descriptor leak in tacpluslib's init_tac_session where close() > was not called for the newly created socket if, for example, destination > host was unreachable > - Port and Timeout TacacsPlus::new() parameters were documented > incorrectly. The are not passed within array references. > > Thanks, > Heikki

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com 5R3MRFM2+X6 Phone +61 7 5598-7474

Fri Mar 13 20:44:51 2020 The RT System itself - Status changed from 'new' to 'open'