Skip Menu |

This queue is for tickets about the PAR-Dist CPAN distribution.

Report information
The Basics
Id: 132067
Status: resolved
Priority: 0/
Queue: PAR-Dist
People
Owner: Nobody in particular
Requestors: SLAFFAN [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Mar 05 17:43:33 2020 SLAFFAN [...] cpan.org - Ticket created
Subject: fix for Archive::Zip related test failures due to symlinks
Many of the current CPAN test failures have this error text (links below): error: Could not extract /tmp/par4D_mq/blib/META.yml safely: /tmp is an existing symbolic link One simple fix is to ensure _unzip_to_tmpdir (or perhaps _unzip) uses a path with symlinks resolved. For example in _unzip_to_tmpdir: ... my $path = $tmpdir; $path = File::Spec->catdir($tmpdir, $args{subdir}) if defined $args{subdir}; ### add these two lines require Cwd; $path = Cwd::realpath($path); _unzip(dist => $dist, path => $path); ... Tested on macos 10.15. Let me know if you'd prefer a patch file, and whether it should be in _unzip_to_tmpdir or more localised within _unzip. Shawn. CPAN testers links: https://www.cpantesters.org/cpan/report/07bf1b62-1c64-11e9-98a9-a7ab3e5edb37 https://www.cpantesters.org/cpan/report/b9d7c082-7a9d-11e9-81af-f28ed51e9e84 https://www.cpantesters.org/cpan/report/9f5989e4-817c-11e9-b3ce-75fdc00df68b
  Sun Nov 08 19:55:28 2020 nieder [...] users.sourceforge.net - Correspondence added
On Thu Mar 05 17:43:33 2020, SLAFFAN wrote: Show quoted text
> Many of the current CPAN test failures have this error text (links > below): > > error: Could not extract /tmp/par4D_mq/blib/META.yml safely: /tmp is > an existing symbolic link > > > > One simple fix is to ensure _unzip_to_tmpdir (or perhaps _unzip) uses > a path with symlinks resolved. > > For example in _unzip_to_tmpdir: > > ... > my $path = $tmpdir; > $path = File::Spec->catdir($tmpdir, $args{subdir}) if defined > $args{subdir}; > ### add these two lines > require Cwd; > $path = Cwd::realpath($path); > > _unzip(dist => $dist, path => $path); > ... > > > Tested on macos 10.15. > > Let me know if you'd prefer a patch file, and whether it should be in > _unzip_to_tmpdir or more localised within _unzip. > > Shawn.
Could you post your current WIP patch? Happy to test on BigSur RC. Thanks.
  Sun Nov 08 19:55:29 2020 The RT System itself - Status changed from 'new' to 'open'
  Sun Nov 08 20:21:12 2020 nieder [...] users.sourceforge.net - Correspondence added
On Sun Nov 08 19:55:28 2020, nieder@users.sourceforge.net wrote: Show quoted text
> On Thu Mar 05 17:43:33 2020, SLAFFAN wrote:
> > Many of the current CPAN test failures have this error text (links > > below): > > > > error: Could not extract /tmp/par4D_mq/blib/META.yml safely: /tmp is > > an existing symbolic link > > > > > > > > One simple fix is to ensure _unzip_to_tmpdir (or perhaps _unzip) uses > > a path with symlinks resolved. > > > > For example in _unzip_to_tmpdir: > > > > ... > > my $path = $tmpdir; > > $path = File::Spec->catdir($tmpdir, $args{subdir}) if defined > > $args{subdir}; > > ### add these two lines > > require Cwd; > > $path = Cwd::realpath($path); > > > > _unzip(dist => $dist, path => $path); > > ... > > > > > > Tested on macos 10.15. > > > > Let me know if you'd prefer a patch file, and whether it should be in > > _unzip_to_tmpdir or more localised within _unzip. > > > > Shawn.
> > Could you post your current WIP patch? Happy to test on BigSur RC. Thanks.
Never mind. I see the provided snippet now. It works with BigSur and the system perl-5.28(.2)
  Mon Nov 09 18:04:44 2020 SLAFFAN [...] cpan.org - Correspondence added
On Sun Nov 08 20:21:12 2020, nieder@users.sourceforge.net wrote: Show quoted text
> On Sun Nov 08 19:55:28 2020, nieder@users.sourceforge.net wrote:
> > On Thu Mar 05 17:43:33 2020, SLAFFAN wrote:
> > > Many of the current CPAN test failures have this error text (links > > > below): > > > > > > error: Could not extract /tmp/par4D_mq/blib/META.yml safely: /tmp > > > is > > > an existing symbolic link > > > > > > > > > > > > One simple fix is to ensure _unzip_to_tmpdir (or perhaps _unzip) > > > uses > > > a path with symlinks resolved. > > > > > > For example in _unzip_to_tmpdir: > > > > > > ... > > > my $path = $tmpdir; > > > $path = File::Spec->catdir($tmpdir, $args{subdir}) if defined > > > $args{subdir}; > > > ### add these two lines > > > require Cwd; > > > $path = Cwd::realpath($path); > > > > > > _unzip(dist => $dist, path => $path); > > > ... > > > > > > > > > Tested on macos 10.15. > > > > > > Let me know if you'd prefer a patch file, and whether it should be > > > in > > > _unzip_to_tmpdir or more localised within _unzip. > > > > > > Shawn.
> > > > Could you post your current WIP patch? Happy to test on BigSur RC. > > Thanks.
> > Never mind. I see the provided snippet now. It works with BigSur and > the system perl-5.28(.2)
Thanks for testing and confirming. Roderich - would it be possible to get this applied? I can work up a PR or patch if you prefer.
  Wed Nov 11 03:30:07 2020 RSCHUPP [...] cpan.org - Correspondence added
On 2020-11-09 18:04:44, SLAFFAN wrote: Show quoted text
> Roderich - would it be possible to get this applied? I can work up a > PR or patch if you prefer.
Hi Shawn, a PR is best. Cheers, Roderich
  Wed Nov 11 03:37:20 2020 SLAFFAN [...] cpan.org - Correspondence added
On Wed Nov 11 03:30:07 2020, RSCHUPP wrote: Show quoted text
> On 2020-11-09 18:04:44, SLAFFAN wrote:
> > Roderich - would it be possible to get this applied? I can work up a > > PR or patch if you prefer.
> > Hi Shawn, > > a PR is best. > > Cheers, Roderich >
Thanks Roderich, but where is the repo? There seems not to be one on GitHub. I have a repo, but it is forked from gitpan.
  Thu Nov 12 10:07:34 2020 RSCHUPP [...] cpan.org - Correspondence added
On 2020-11-11 03:37:20, SLAFFAN wrote: Show quoted text
> Thanks Roderich, but where is the repo? There seems not to be one on > GitHub.
Yikes, you're right. I had to "git svn clone" from a dump of the original OpenFoundry Subversion repository. And then "synthesize" release tags using the Changes file, as the previous developers didn't use tags :( Now there's https://github.com/rschupp/PAR-Dist Cheers, Roderich
  Thu Nov 12 15:49:20 2020 SLAFFAN [...] cpan.org - Correspondence added
On Thu Nov 12 10:07:34 2020, RSCHUPP wrote: Show quoted text
> On 2020-11-11 03:37:20, SLAFFAN wrote:
> > Thanks Roderich, but where is the repo? There seems not to be one on > > GitHub.
> > Yikes, you're right. I had to "git svn clone" from a dump of the > original OpenFoundry Subversion repository. > And then "synthesize" release tags using the Changes file, as the > previous developers didn't use tags :( > Now there's https://github.com/rschupp/PAR-Dist > > Cheers, Roderich
Thanks for creating the repo. PR submitted in https://github.com/rschupp/PAR-Dist/pull/1
  Tue Nov 17 04:52:17 2020 RSCHUPP [...] cpan.org - Correspondence added
On 2020-11-12 15:49:20, SLAFFAN wrote: Show quoted text
> PR submitted in https://github.com/rschupp/PAR-Dist/pull/1
Released as PAR::Dist 0.50 Cheers, Roderich
  Tue Nov 17 04:52:19 2020 RSCHUPP [...] cpan.org - Status changed from 'open' to 'resolved'