Skip Menu |

This queue is for tickets about the Module-Release-CSJEWELL CPAN distribution.

Report information
The Basics
Id: 131935
Status: open
Priority: 0/
Queue: Module-Release-CSJEWELL

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.101
Fixed in: (no value)



Subject: perlcritic test fails
See subject. Excerpt of test log: ... Policy "Perl::Critic::Policy::Miscellanea::RequireRcsKeywords" is not installed. Policy "Perl::Critic::Policy::Miscellanea::RequireRcsKeywords" is not installed. # Failed test 'Test::Perl::Critic for "blib/lib/Module/Release/UploadOwnSite.pm"' # at /usr/perl5.28.1Dp/lib/site_perl/5.28.1/Test/Perl/Critic.pm line 121. # # blib/lib/Module/Release/UploadOwnSite.pm:1:1: # Documentation::PodSpelling: Check the spelling in your POD: csjewell releaserc MERCHANTABILITY LICENCE # blib/lib/Module/Release/UploadOwnSite.pm:11:1: # ValuesAndExpressions::RequireConstantVersion: $VERSION value must be a constant # blib/lib/Module/Release/UploadOwnSite.pm:87:1: # Documentation::RequirePodLinksIncludeText: Link L<Module::Release> on line 91 does not specify text # blib/lib/Module/Release/UploadOwnSite.pm:87:1: # Documentation::RequirePodLinksIncludeText: Link L<perlartistic> on line 136 does not specify text # blib/lib/Module/Release/UploadOwnSite.pm:87:1: # Documentation::RequirePodLinksIncludeText: Link L<perlgpl> on line 136 does not specify text # Failed test 'Test::Perl::Critic for "blib/lib/Module/Release/PermissionFix.pm"' # at /usr/perl5.28.1Dp/lib/site_perl/5.28.1/Test/Perl/Critic.pm line 121. # # blib/lib/Module/Release/PermissionFix.pm:1:1: # CodeLayout::RequireTidyCode: Code is not tidy # blib/lib/Module/Release/PermissionFix.pm:1:1: # Documentation::PodSpelling: Check the spelling in your POD: gz csjewell MERCHANTABILITY LICENCE # blib/lib/Module/Release/PermissionFix.pm:13:1: # ValuesAndExpressions::RequireConstantVersion: $VERSION value must be a constant # blib/lib/Module/Release/PermissionFix.pm:68:59: # ValuesAndExpressions::RequireConstantOnLeftSideOfEquality: Constant value on right side of equality # blib/lib/Module/Release/PermissionFix.pm:88:14: # Variables::ProhibitPunctuationVars: Magic punctuation variable $! used in interpolated string # blib/lib/Module/Release/PermissionFix.pm:99:1: # Documentation::RequirePodLinksIncludeText: Link L<Module::Release> on line 103 does not specify text # blib/lib/Module/Release/PermissionFix.pm:99:1: # Documentation::RequirePodLinksIncludeText: Link L<perlartistic> on line 120 does not specify text # blib/lib/Module/Release/PermissionFix.pm:99:1: # Documentation::RequirePodLinksIncludeText: Link L<perlgpl> on line 120 does not specify text # Failed test 'Test::Perl::Critic for "blib/lib/Module/Release/CSJEWELL.pm"' # at /usr/perl5.28.1Dp/lib/site_perl/5.28.1/Test/Perl/Critic.pm line 121. # # blib/lib/Module/Release/CSJEWELL.pm:1:1: # Documentation::PodSpelling: Check the spelling in your POD: CSJEWELL releaserc CPAN MERCHANTABILITY LICENCE # blib/lib/Module/Release/CSJEWELL.pm:8:1: # ValuesAndExpressions::RequireConstantVersion: $VERSION value must be a constant # blib/lib/Module/Release/CSJEWELL.pm:14:1: # Documentation::RequirePodLinksIncludeText: Link L<perlartistic> on line 121 does not specify text # blib/lib/Module/Release/CSJEWELL.pm:14:1: # Documentation::RequirePodLinksIncludeText: Link L<perlgpl> on line 121 does not specify text # Failed test 'Test::Perl::Critic for "blib/lib/Module/Release/OpenRepository.pm"' # at /usr/perl5.28.1Dp/lib/site_perl/5.28.1/Test/Perl/Critic.pm line 121. # # blib/lib/Module/Release/OpenRepository.pm:1:1: # Documentation::PodSpelling: Check the spelling in your POD: csjewell releaserc MERCHANTABILITY LICENCE # blib/lib/Module/Release/OpenRepository.pm:11:1: # ValuesAndExpressions::RequireConstantVersion: $VERSION value must be a constant # blib/lib/Module/Release/OpenRepository.pm:55:25: # RegularExpressions::ProhibitEscapedMetacharacters: Use character classes for literal metachars instead of escapes # blib/lib/Module/Release/OpenRepository.pm:66:1: # Documentation::RequirePodLinksIncludeText: Link L<Module::Release> on line 70 does not specify text # blib/lib/Module/Release/OpenRepository.pm:66:1: # Documentation::RequirePodLinksIncludeText: Link L<perlartistic> on line 104 does not specify text # blib/lib/Module/Release/OpenRepository.pm:66:1: # Documentation::RequirePodLinksIncludeText: Link L<perlgpl> on line 104 does not specify text # Failed test 'Test::Perl::Critic for "blib/lib/Module/Release/Twitter.pm"' # at /usr/perl5.28.1Dp/lib/site_perl/5.28.1/Test/Perl/Critic.pm line 121. # # blib/lib/Module/Release/Twitter.pm:1:1: # Documentation::PodSpelling: Check the spelling in your POD: csjewell releaserc MERCHANTABILITY LICENCE # blib/lib/Module/Release/Twitter.pm:13:1: # ValuesAndExpressions::RequireConstantVersion: $VERSION value must be a constant # blib/lib/Module/Release/Twitter.pm:97:1: # Documentation::RequirePodLinksIncludeText: Link L<Module::Release> on line 101 does not specify text # blib/lib/Module/Release/Twitter.pm:97:1: # Documentation::RequirePodLinksIncludeText: Link L<perlartistic> on line 143 does not specify text # blib/lib/Module/Release/Twitter.pm:97:1: # Documentation::RequirePodLinksIncludeText: Link L<perlgpl> on line 143 does not specify text t/800_perlcritic.t ...... Dubious, test returned 1 (wstat 256, 0x100) Failed 5/5 subtests ...
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};