Skip Menu |

This queue is for tickets about the Gtk3 CPAN distribution.

Report information
The Basics
Id: 131871
Status: resolved
Priority: 0/
Queue: Gtk3

People
Owner: Nobody in particular
Requestors: gaetan [...] frenoy.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Gtk3::TreeModelSort::new_with_model fails as of Gtk 3.24.14
Date: Wed, 19 Feb 2020 21:03:45 +0100
To: bug-Gtk3 [...] rt.cpan.org
From: Gaëtan Frenoy <gaetan [...] frenoy.net>
Hello, Since the release of Gtk 3.24.14 (see https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/NEWS) and the fix of introspection issue for GtkTreeModelSort.new_with_model(), see https://gitlab.gnome.org/GNOME/gtk/issues/1077 ; the perl "fix" for that issue is actually breaking existing code (see https://github.com/asbru-cm/asbru-cm/issues/421). I'm not a perl guru so there is problably a better way to fix this but here is my suggestion for Gtk3::TreeModelSort::new_with_model: sub Gtk3::TreeModelSort::new_with_model {   my ($class, $child_model) = @_;   if (Gtk3::get_major_version() > 3 || Gtk3::get_minor_version() > 24 || Gtk3::get_micro_version() >= 14) {     Glib::Object::Introspection->invoke (       $_GTK_BASENAME, 'TreeModelSort', 'new_with_model', $class, $child_model);   } else {     Glib::Object::Introspection->invoke (       $_GTK_BASENAME, 'TreeModel', 'sort_new_with_model', $child_model);   } } Can you include this change (or something similar) and release a new version of Gtk3-perl interface ? Existing application using your great work will really appreciate it :-) Thanks for your help, -- Gaëtan
On Wed Feb 19 15:12:23 2020, gaetan@frenoy.net wrote: Show quoted text
> Hello, > > Since the release of Gtk 3.24.14 (see > https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/NEWS) and the fix of > introspection issue for GtkTreeModelSort.new_with_model(), see > https://gitlab.gnome.org/GNOME/gtk/issues/1077 ; the perl "fix" for that > issue is actually breaking existing code (see > https://github.com/asbru-cm/asbru-cm/issues/421).
Thanks for the report and the suggested change. A similar suggestion was filed as <https://gitlab.gnome.org/GNOME/perl-gtk3/issues/5>, and I just pushed <https://gitlab.gnome.org/GNOME/perl-gtk3/-/commit/b857d1c1bf1ce29813639d35b5459755ec08462c> based on this. Please test.
Subject: Re: [rt.cpan.org #131871] Gtk3::TreeModelSort::new_with_model fails as of Gtk 3.24.14
Date: Sat, 14 Mar 2020 09:52:36 +0100
To: bug-Gtk3 [...] rt.cpan.org
From: Gaëtan Frenoy <gaetan [...] frenoy.net>
Thanks Torsten ! The fix has been tested, it now works as expected :) Have a great day. On 8/03/20 11:11, Torsten Schoenfeld via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=131871 > > > On Wed Feb 19 15:12:23 2020, gaetan@frenoy.net wrote:
>> Hello, >> >> Since the release of Gtk 3.24.14 (see >> https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/NEWS) and the fix of >> introspection issue for GtkTreeModelSort.new_with_model(), see >> https://gitlab.gnome.org/GNOME/gtk/issues/1077 ; the perl "fix" for that >> issue is actually breaking existing code (see >> https://github.com/asbru-cm/asbru-cm/issues/421).
> Thanks for the report and the suggested change. A similar suggestion was filed as <https://gitlab.gnome.org/GNOME/perl-gtk3/issues/5>, and I just pushed <https://gitlab.gnome.org/GNOME/perl-gtk3/-/commit/b857d1c1bf1ce29813639d35b5459755ec08462c> based on this. Please test.