Bug #13184 for Net-DNS: debug message not if debug'd

Fri Jun 10 01:05:37 2005 Guest - Ticket created

Subject:

debug message not if debug'd

line 1063 of Net/DNS/Resolver/Base.pm : print ";; remote addr struc: ".unpack("H*", $dst_sockaddr)."\n"; should be conditionally printed only when debug is enabled. The correct code should be (including its preceeding conditionally printed line): if $self->{'debug'} { print ";; bgsend($ns_address : $dstport)\n" print ";; remote addr struc: ".unpack("H*", $dst_sockaddr)."\n"; }

Fri Jun 10 01:06:38 2005 Guest - Correspondence added

[guest - Fri Jun 10 01:05:37 2005]: oops, missed a semicolon. included below. Show quoted text

> line 1063 of Net/DNS/Resolver/Base.pm : > > print ";; remote addr struc: ".unpack("H*", > $dst_sockaddr)."\n"; > > should be conditionally printed only when debug is enabled. The > correct code should be (including its preceeding conditionally > printed line): > > if $self->{'debug'} { > print ";; bgsend($ns_address : $dstport)\n"; > print ";; remote addr struc: ".unpack("H*", > $dst_sockaddr)."\n"; > }

Fri Jun 10 03:15:09 2005 OLAF [...] cpan.org - Correspondence added

Thanks!!! Its a little embarassing. Does this bite enough for immediate release of 0.51? In other words how did you notice? Did this break another program, clutter logfiles?? I notice that the test suite does not hit this problem, not even with TEST_VERBOSE. I'll put adding tests on bgsend to my TODO list. --Olaf [guest - Fri Jun 10 01:06:38 2005]: Show quoted text

> [guest - Fri Jun 10 01:05:37 2005]: > > oops, missed a semicolon. included below. >

> > line 1063 of Net/DNS/Resolver/Base.pm : > > > > print ";; remote addr struc: ".unpack("H*", > > $dst_sockaddr)."\n"; > > > > should be conditionally printed only when debug is enabled. The > > correct code should be (including its preceeding conditionally > > printed line): > > > > if $self->{'debug'} { > > print ";; bgsend($ns_address : $dstport)\n"; > > print ";; remote addr struc: ".unpack("H*", > > $dst_sockaddr)."\n"; > > }

> >

Fri Jun 10 03:15:09 2005 OLAF [...] cpan.org - Status changed from 'new' to 'open'

Fri Jun 10 03:31:46 2005 Guest - Correspondence added

From:

Mike C

[OLAF - Fri Jun 10 03:15:09 2005]: Show quoted text

> > Thanks!!! > > Its a little embarassing. > > Does this bite enough for immediate release of 0.51? In other words > how did you notice? > Did this break another program, clutter logfiles?? > > I notice that the test suite does not hit this problem, not even with > TEST_VERBOSE. I'll put > adding tests on bgsend to my TODO list. > > --Olaf >

No problem and no embarassment warranted. I noticed the output cluttering my mail logs, and when manually running spamassassin. You can reproduce by pumping some STDIN into spamassassin. Log analysis progs such as logwatch will produce false positives on the clutter, but would not be fatal. If you can release a .51, that might help reduce anxiety for mail server admins. Hopefully in the meantime they'll find this info and apply a manual quickfix. Thanks for the prompt attention Olaf!

Fri Jun 10 07:01:24 2005 OLAF [...] cpan.org - Correspondence added

Show quoted text

> If you can release a .51, that might help reduce anxiety for mail > server > admins.

Version 0.51 has just been pushed to CPAN. Should appear in a few hours. Thanks for the bug report. --Olaf

Wed Jun 22 16:55:57 2005 OLAF [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Jun 22 16:55:57 2005 OLAF [...] cpan.org - Fixed in 0.51 added