Bug #131684 for Dist-Zilla-Plugin-DynamicPrereqs: Test failure on perl 5.28

Tue Feb 04 16:45:20 2020 djerius [...] cpan.org - Ticket created

Subject:

Test failure on perl 5.28

Howdy, I'm getting a test failure. Attached is the build log. Please let me know how I can help debug this. Thanks, Diab

Subject:

build.log

Message body is not shown because it is too large.

Tue Feb 04 16:50:26 2020 ether [...] cpan.org - Correspondence added

On 2020-02-04 13:45:20, DJERIUS wrote: Show quoted text

> Howdy, > > I'm getting a test failure. Attached is the build log. > > Please let me know how I can help debug this.

The failure is quite straightforward. Why do you not have CPAN installed, when it is a core module?

Tue Feb 04 16:50:27 2020 The RT System itself - Status changed from 'new' to 'open'

Tue Feb 04 16:56:13 2020 djerius [...] cpan.org - Correspondence added

On Tue Feb 04 16:50:26 2020, ETHER wrote: Show quoted text

> On 2020-02-04 13:45:20, DJERIUS wrote:

> > Howdy, > > > > I'm getting a test failure. Attached is the build log. > > > > Please let me know how I can help debug this.

> > The failure is quite straightforward. Why do you not have CPAN > installed, when it is a core module?

Strangely enough, my computer disagrees with your diagnosis: perl -MCPAN -e "CPAN::Shell->install('Dist::Zilla::Plugin::DynamicPrereqs')" CPAN: File::HomeDir loaded ok (v1.004) Reading '/home/dj/tmp/cpan/Metadata' Database was generated on Tue, 04 Feb 2020 18:29:03 GMT Running install for module 'Dist::Zilla::Plugin::DynamicPrereqs' CPAN: YAML loaded ok (v1.29) CPAN: CPAN::Kwalify loaded ok (v5.50) CPAN: Digest::SHA loaded ok (v6.01) CPAN: Compress::Zlib loaded ok (v2.074) Checksum for /home/dj/tmp/cpan/sources/authors/id/E/ET/ETHER/Dist-Zilla-Plugin-DynamicPrereqs-0.036.tar.gz ok CPAN: Archive::Tar loaded ok (v2.30) Dist-Zilla-Plugin-DynamicPrereqs-0.036/ Dist-Zilla-Plugin-DynamicPrereqs-0.036/INSTALL Dist-Zilla-Plugin-DynamicPrereqs-0.036/CONTRIBUTING Dist-Zilla-Plugin-DynamicPrereqs-0.036/Changes Dist-Zilla-Plugin-DynamicPrereqs-0.036/MANIFEST Dist-Zilla-Plugin-DynamicPrereqs-0.036/t/ Dist-Zilla-Plugin-DynamicPrereqs-0.036/xt/ Dist-Zilla-Plugin-DynamicPrereqs-0.036/README Dist-Zilla-Plugin-DynamicPrereqs-0.036/META.yml Dist-Zilla-Plugin-DynamicPrereqs-0.036/lib/ Dist-Zilla-Plugin-DynamicPrereqs-0.036/Makefile.PL Dist-Zilla-Plugin-DynamicPrereqs-0.036/LICENCE Dist-Zilla-Plugin-DynamicPrereqs-0.036/META.json Dist-Zilla-Plugin-DynamicPrereqs-0.036/share/ Dist-Zilla-Plugin-DynamicPrereqs-0.036/dist.ini Dist-Zilla-Plugin-DynamicPrereqs-0.036/share/DynamicPrereqs/ .... Could something else be wrong?

Tue Feb 04 17:03:05 2020 djerius [...] cpan.org - Correspondence added

On Tue Feb 04 16:56:13 2020, DJERIUS wrote: Show quoted text

> On Tue Feb 04 16:50:26 2020, ETHER wrote:

> > On 2020-02-04 13:45:20, DJERIUS wrote:

> > > Howdy, > > > > > > I'm getting a test failure. Attached is the build log. > > > > > > Please let me know how I can help debug this.

> > > > The failure is quite straightforward. Why do you not have CPAN > > installed, when it is a core module?

> > Strangely enough, my computer disagrees with your diagnosis: > > perl -MCPAN -e "CPAN::Shell-

> >install('Dist::Zilla::Plugin::DynamicPrereqs')"

> CPAN: File::HomeDir loaded ok (v1.004) > Reading '/home/dj/tmp/cpan/Metadata' > Database was generated on Tue, 04 Feb 2020 18:29:03 GMT > Running install for module 'Dist::Zilla::Plugin::DynamicPrereqs' > CPAN: YAML loaded ok (v1.29) > CPAN: CPAN::Kwalify loaded ok (v5.50) > CPAN: Digest::SHA loaded ok (v6.01) > CPAN: Compress::Zlib loaded ok (v2.074) > Checksum for /home/dj/tmp/cpan/sources/authors/id/E/ET/ETHER/Dist- > Zilla-Plugin-DynamicPrereqs-0.036.tar.gz ok > CPAN: Archive::Tar loaded ok (v2.30) > Dist-Zilla-Plugin-DynamicPrereqs-0.036/ > Dist-Zilla-Plugin-DynamicPrereqs-0.036/INSTALL > Dist-Zilla-Plugin-DynamicPrereqs-0.036/CONTRIBUTING > Dist-Zilla-Plugin-DynamicPrereqs-0.036/Changes > Dist-Zilla-Plugin-DynamicPrereqs-0.036/MANIFEST > Dist-Zilla-Plugin-DynamicPrereqs-0.036/t/ > Dist-Zilla-Plugin-DynamicPrereqs-0.036/xt/ > Dist-Zilla-Plugin-DynamicPrereqs-0.036/README > Dist-Zilla-Plugin-DynamicPrereqs-0.036/META.yml > Dist-Zilla-Plugin-DynamicPrereqs-0.036/lib/ > Dist-Zilla-Plugin-DynamicPrereqs-0.036/Makefile.PL > Dist-Zilla-Plugin-DynamicPrereqs-0.036/LICENCE > Dist-Zilla-Plugin-DynamicPrereqs-0.036/META.json > Dist-Zilla-Plugin-DynamicPrereqs-0.036/share/ > Dist-Zilla-Plugin-DynamicPrereqs-0.036/dist.ini > Dist-Zilla-Plugin-DynamicPrereqs-0.036/share/DynamicPrereqs/ > > .... > > > Could something else be wrong?

Here's a more detailed log from the test that's failing: perl -Mblib t/18-subs.t # loading CPAN::Meta::Requirements 2.120620 # loading Module::Metadata 0 # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin-DynamicPrereqs/include_subs/has_module ok 1 - CPAN has not already been loaded not ok 2 - CPAN is installed; returned something true # Failed test 'CPAN is installed; returned something true' # at t/18-subs.t line 48. ok 3 - CPAN is installed at least version 0 ok 4 - CPAN has not been loaded by has_module() CPAN: File::HomeDir loaded ok (v1.004) not ok 5 - has_version returned $CPAN::VERSION # Failed test 'has_version returned $CPAN::VERSION' # at t/18-subs.t line 53. # got: undef # expected: '2.27' ok 6 - Bloop::Blorp has not already been loaded ok 7 - Bloop::Blorp is not installed ok 8 - Bloop::Blorp has not been loaded by has_module() ok 9 - Dist::Zilla::Plugin::DynamicPrereqs has already been loaded ok 10 - Dist::Zilla::Plugin::DynamicPrereqs is installed; returned its version ok 11 - Dist::Zilla::Plugin::DynamicPrereqs is installed at least version 0 ok 12 - Dist::Zilla::Plugin::DynamicPrereqs is installed at least version 0.036 # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin-DynamicPrereqs/include_subs/runtime_requires # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin-DynamicPrereqs/include_subs/test_requires # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin-DynamicPrereqs/include_subs/requires # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin-DynamicPrereqs/include_subs/build_requires # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin-DynamicPrereqs/include_subs/_add_prereq ok 13 - %WriteMakefileArgs is correctly updated ok 14 - %FallbackPrereqs is correctly updated 1..14 # Looks like you failed 2 tests of 14.

Tue Feb 04 17:13:10 2020 djerius [...] cpan.org - Correspondence added

On Tue Feb 04 17:03:05 2020, DJERIUS wrote: Show quoted text

> On Tue Feb 04 16:56:13 2020, DJERIUS wrote:

> > On Tue Feb 04 16:50:26 2020, ETHER wrote:

> > > On 2020-02-04 13:45:20, DJERIUS wrote:

> > > > Howdy, > > > > > > > > I'm getting a test failure. Attached is the build log. > > > > > > > > Please let me know how I can help debug this.

> > > > > > The failure is quite straightforward. Why do you not have CPAN > > > installed, when it is a core module?

> > > > Strangely enough, my computer disagrees with your diagnosis: > > > > perl -MCPAN -e "CPAN::Shell-

> > > install('Dist::Zilla::Plugin::DynamicPrereqs')"

> > CPAN: File::HomeDir loaded ok (v1.004) > > Reading '/home/dj/tmp/cpan/Metadata' > > Database was generated on Tue, 04 Feb 2020 18:29:03 GMT > > Running install for module 'Dist::Zilla::Plugin::DynamicPrereqs' > > CPAN: YAML loaded ok (v1.29) > > CPAN: CPAN::Kwalify loaded ok (v5.50) > > CPAN: Digest::SHA loaded ok (v6.01) > > CPAN: Compress::Zlib loaded ok (v2.074) > > Checksum for /home/dj/tmp/cpan/sources/authors/id/E/ET/ETHER/Dist- > > Zilla-Plugin-DynamicPrereqs-0.036.tar.gz ok > > CPAN: Archive::Tar loaded ok (v2.30) > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/ > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/INSTALL > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/CONTRIBUTING > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/Changes > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/MANIFEST > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/t/ > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/xt/ > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/README > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/META.yml > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/lib/ > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/Makefile.PL > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/LICENCE > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/META.json > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/share/ > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/dist.ini > > Dist-Zilla-Plugin-DynamicPrereqs-0.036/share/DynamicPrereqs/ > > > > .... > > > > > > Could something else be wrong?

> > > Here's a more detailed log from the test that's failing: > perl -Mblib t/18-subs.t > # loading CPAN::Meta::Requirements 2.120620 > # loading Module::Metadata 0 > # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin- > DynamicPrereqs/include_subs/has_module > ok 1 - CPAN has not already been loaded > not ok 2 - CPAN is installed; returned something true > # Failed test 'CPAN is installed; returned something true' > # at t/18-subs.t line 48. > ok 3 - CPAN is installed at least version 0 > ok 4 - CPAN has not been loaded by has_module() > CPAN: File::HomeDir loaded ok (v1.004) > not ok 5 - has_version returned $CPAN::VERSION > # Failed test 'has_version returned $CPAN::VERSION' > # at t/18-subs.t line 53. > # got: undef > # expected: '2.27' > ok 6 - Bloop::Blorp has not already been loaded > ok 7 - Bloop::Blorp is not installed > ok 8 - Bloop::Blorp has not been loaded by has_module() > ok 9 - Dist::Zilla::Plugin::DynamicPrereqs has already been loaded > ok 10 - Dist::Zilla::Plugin::DynamicPrereqs is installed; returned its > version > ok 11 - Dist::Zilla::Plugin::DynamicPrereqs is installed at least > version 0 > ok 12 - Dist::Zilla::Plugin::DynamicPrereqs is installed at least > version 0.036 > # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin- > DynamicPrereqs/include_subs/runtime_requires > # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin- > DynamicPrereqs/include_subs/test_requires > # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin- > DynamicPrereqs/include_subs/requires > # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin- > DynamicPrereqs/include_subs/build_requires > # loading /tmp/lUzFYZeQa3/auto/share/module/Dist-Zilla-Plugin- > DynamicPrereqs/include_subs/_add_prereq > ok 13 - %WriteMakefileArgs is correctly updated > ok 14 - %FallbackPrereqs is correctly updated > 1..14 > # Looks like you failed 2 tests of 14.

Ok, found the problem. has_module() uses Module::Metadata. We have a shim CPAN module which does some per-user tweaking to handle some remote filesystems issues we've had, and then loads the ligit CPAN. Looks like I'll to perform a better masquerade. Sorry for the noise. Diab

Wed Feb 05 04:21:57 2020 haarg [...] haarg.org - Correspondence added

It would probably be more reasonable for the test to check using a module included with the dist, such as the already included Inlined::Module, rather than CPAN.pm. It would be more predictable, avoid the (currently undeclared) dependency, and avoid any possible odd interactions CPAN.pm might have.

Sat Feb 15 13:42:05 2020 ether [...] cpan.org - Correspondence added

On 2020-02-05 01:21:57, haarg wrote: Show quoted text

> It would probably be more reasonable for the test to check using a > module included with the dist, such as the already included > Inlined::Module, rather than CPAN.pm. It would be more predictable, > avoid the (currently undeclared) dependency, and avoid any possible > odd interactions CPAN.pm might have.

That is fair. I chose CPAN.pm because, being in core, it can be reasonably assumed to be installed, but this is not always true with some operating system distributions.

Sun Feb 16 11:57:31 2020 ether [...] cpan.org - Correspondence added

and I have done so in 0.037.

Sun Feb 16 11:57:31 2020 ether [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Feb 16 11:57:32 2020 ether [...] cpan.org - Fixed in 0.037 added