Bug #131615 for CPAN: t/31sessions.t fails with YAML-1.30

Thu Jan 30 07:11:07 2020 ppisar [...] redhat.com - Ticket created

Subject:

t/31sessions.t fails with YAML-1.30

After upgrading YAML 1.29 to 1.30, t/31sessions.t test fails like this: ok 50 - opening new session 'the historically second' # error while running '"/usr/bin/perl" "-I/home/test/fedora/perl-CPAN/CPAN-2.27/t" "-Mblib" "-MCPAN::MyConfig_46610" "-Mlocal_utils" "-MCPAN" "-e" "local_utils::dup_pid_inc(46610);" "-e" "@CPAN::Defaultsites = (); shell" > test-46610.out' on 'the historically second': not ok 51 - cmd[get CPAN::Test::Dummy::Perl5::Make] # Failed test 'cmd[get CPAN::Test::Dummy::Perl5::Make]' # at t/31sessions.t line 562. # 'CPAN: LWP::UserAgent loaded ok (v6.43) # CPAN: URI::URL loaded ok (v5.04) # CPAN: YAML loaded ok (v1.30) # Reading '/home/test/fedora/perl-CPAN/CPAN-2.27/t/CPAN/authors/01mailrc.txt' # Reading 11 yaml files from /home/test/fedora/perl-CPAN/CPAN-2.27/t/dot-cpan-46610/build/ # ' # doesn't match '/Has already been unwrapped/' ##9(the historically second)/0:{q['get CPAN::Test::Dummy::Perl5::Make']=>q['CPAN: LWP::UserAgent loaded ok (v6.43) CPAN: URI::URL loaded ok (v5.04) CPAN: YAML loaded ok (v1.30) Reading \'/home/test/fedora/perl-CPAN/CPAN-2.27/t/CPAN/authors/01mailrc.txt\' Reading 11 yaml files from /home/test/fedora/perl-CPAN/CPAN-2.27/t/dot-cpan-46610/build/ ']} not ok 52 - cmd[make CPAN/Test/Dummy/Perl5/Make.pm] # Failed test 'cmd[make CPAN/Test/Dummy/Perl5/Make.pm]' # at t/31sessions.t line 562. # 'Reading '/home/test/fedora/perl-CPAN/CPAN-2.27/t/CPAN/authors/01mailrc.txt' # ............................................................................DONE [...] Test Summary Report ------------------- t/31sessions.t (Wstat: 7168 Tests: 92 Failed: 28) Failed tests: 51-61, 63-66, 68, 71, 74, 77-82, 84, 89-91 Non-zero exit status: 28 This is probably triggered by this <https://github.com/ingydotnet/yaml-pm/commit/7736f38bd02e4f9f77d5468721e3be3d7b34a8ec> YAML change.

Thu Jan 30 07:40:08 2020 TINITA [...] cpan.org - Correspondence added

On Thu Jan 30 13:11:07 2020, ppisar wrote: Show quoted text

> After upgrading YAML 1.29 to 1.30, t/31sessions.t test fails like > this:

I tried to fix it by adding `$YAML::LoadBlessed = 1` but so far failed to find the right position in the test to do that...

Thu Jan 30 07:40:08 2020 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 30 11:10:10 2020 jkeenan [...] cpan.org - Correspondence added

On Thu Jan 30 07:11:07 2020, ppisar wrote: Show quoted text

> After upgrading YAML 1.29 to 1.30, t/31sessions.t test fails like > this: > > ok 50 - opening new session 'the historically second' > # error while running '"/usr/bin/perl" "-I/home/test/fedora/perl- > CPAN/CPAN-2.27/t" "-Mblib" "-MCPAN::MyConfig_46610" "-Mlocal_utils" "- > MCPAN" "-e" "local_utils::dup_pid_inc(46610);" "-e" > "@CPAN::Defaultsites = (); shell" > test-46610.out' on 'the > historically second': > not ok 51 - cmd[get CPAN::Test::Dummy::Perl5::Make] > # Failed test 'cmd[get CPAN::Test::Dummy::Perl5::Make]' > # at t/31sessions.t line 562. > # 'CPAN: LWP::UserAgent loaded ok (v6.43) > # CPAN: URI::URL loaded ok (v5.04) > # CPAN: YAML loaded ok (v1.30) > # Reading '/home/test/fedora/perl-CPAN/CPAN- > 2.27/t/CPAN/authors/01mailrc.txt' > # Reading 11 yaml files from /home/test/fedora/perl-CPAN/CPAN- > 2.27/t/dot-cpan-46610/build/ > # ' > # doesn't match '/Has already been unwrapped/' > ##9(the historically second)/0:{q['get > CPAN::Test::Dummy::Perl5::Make']=>q['CPAN: LWP::UserAgent loaded ok > (v6.43) > CPAN: URI::URL loaded ok (v5.04) > CPAN: YAML loaded ok (v1.30) > Reading \'/home/test/fedora/perl-CPAN/CPAN- > 2.27/t/CPAN/authors/01mailrc.txt\' > Reading 11 yaml files from /home/test/fedora/perl-CPAN/CPAN- > 2.27/t/dot-cpan-46610/build/ > ']} > not ok 52 - cmd[make CPAN/Test/Dummy/Perl5/Make.pm] > # Failed test 'cmd[make CPAN/Test/Dummy/Perl5/Make.pm]' > # at t/31sessions.t line 562. > # 'Reading '/home/test/fedora/perl-CPAN/CPAN- > 2.27/t/CPAN/authors/01mailrc.txt' > # > ............................................................................DONE > [...] > Test Summary Report > ------------------- > t/31sessions.t (Wstat: 7168 Tests: 92 Failed: 28) > Failed tests: 51-61, 63-66, 68, 71, 74, 77-82, 84, 89-91 > Non-zero exit status: 28 > > This is probably triggered by this > <https://github.com/ingydotnet/yaml- > pm/commit/7736f38bd02e4f9f77d5468721e3be3d7b34a8ec> YAML change.

I get these failures as well with perl-5.30.1 (actually, perl built at tag v5.30.1) and YAML-1.30. Unlike the failures in t/12cpan.t being discussed in https://rt.cpan.org/Ticket/Display.html?id=131602, YAML::Syck has no bearing on these failures. I first installed YAML, built CPAN, and called 'prove' on t/31sessions.t. Test failures. I then uninstalled YAML, installed YAML::Syck, built and tested. No test failures. So the failures can be diagrammed as follows: ##### t/12cpan.t -> fails with YAML::Syck t/31sessions.t -> fails with YAML ##### Is this diagnosis correct? Thank you very much. Jim Keenan

Thu Jan 30 11:21:46 2020 jkeenan [...] cpan.org - Correspondence added

On Thu Jan 30 11:10:10 2020, JKEENAN wrote: Show quoted text

> On Thu Jan 30 07:11:07 2020, ppisar wrote:

> > After upgrading YAML 1.29 to 1.30, t/31sessions.t test fails like > > this: > > > > ok 50 - opening new session 'the historically second' > > # error while running '"/usr/bin/perl" "-I/home/test/fedora/perl- > > CPAN/CPAN-2.27/t" "-Mblib" "-MCPAN::MyConfig_46610" "-Mlocal_utils" > > "- > > MCPAN" "-e" "local_utils::dup_pid_inc(46610);" "-e" > > "@CPAN::Defaultsites = (); shell" > test-46610.out' on 'the > > historically second': > > not ok 51 - cmd[get CPAN::Test::Dummy::Perl5::Make] > > # Failed test 'cmd[get CPAN::Test::Dummy::Perl5::Make]' > > # at t/31sessions.t line 562. > > # 'CPAN: LWP::UserAgent loaded ok (v6.43) > > # CPAN: URI::URL loaded ok (v5.04) > > # CPAN: YAML loaded ok (v1.30) > > # Reading '/home/test/fedora/perl-CPAN/CPAN- > > 2.27/t/CPAN/authors/01mailrc.txt' > > # Reading 11 yaml files from /home/test/fedora/perl-CPAN/CPAN- > > 2.27/t/dot-cpan-46610/build/ > > # ' > > # doesn't match '/Has already been unwrapped/' > > ##9(the historically second)/0:{q['get > > CPAN::Test::Dummy::Perl5::Make']=>q['CPAN: LWP::UserAgent loaded ok > > (v6.43) > > CPAN: URI::URL loaded ok (v5.04) > > CPAN: YAML loaded ok (v1.30) > > Reading \'/home/test/fedora/perl-CPAN/CPAN- > > 2.27/t/CPAN/authors/01mailrc.txt\' > > Reading 11 yaml files from /home/test/fedora/perl-CPAN/CPAN- > > 2.27/t/dot-cpan-46610/build/ > > ']} > > not ok 52 - cmd[make CPAN/Test/Dummy/Perl5/Make.pm] > > # Failed test 'cmd[make CPAN/Test/Dummy/Perl5/Make.pm]' > > # at t/31sessions.t line 562. > > # 'Reading '/home/test/fedora/perl-CPAN/CPAN- > > 2.27/t/CPAN/authors/01mailrc.txt' > > # > > ............................................................................DONE > > [...] > > Test Summary Report > > ------------------- > > t/31sessions.t (Wstat: 7168 Tests: 92 Failed: 28) > > Failed tests: 51-61, 63-66, 68, 71, 74, 77-82, 84, 89-91 > > Non-zero exit status: 28 > > > > This is probably triggered by this > > <https://github.com/ingydotnet/yaml- > > pm/commit/7736f38bd02e4f9f77d5468721e3be3d7b34a8ec> YAML change.

> > I get these failures as well with perl-5.30.1 (actually, perl built at > tag v5.30.1) and YAML-1.30. > > Unlike the failures in t/12cpan.t being discussed in > https://rt.cpan.org/Ticket/Display.html?id=131602, YAML::Syck has no > bearing on these failures. I first installed YAML, built CPAN, and > called 'prove' on t/31sessions.t. Test failures. I then uninstalled > YAML, installed YAML::Syck, built and tested. No test failures. >

I was partially wrong there. When I de-installed YAML and installed YAML::Syck, then built CPAN and called 'prove' on t/31-sessions.t, the file was graded NOTESTS because all unit tests were skipped due to absence of YAML. ##### $ thisprove -vb t/31sessions.t t/31sessions.t .. 1..0 # SKIP Yaml module [YAML] not installed skipped: Yaml module [YAML] not installed Files=1, Tests=0, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.20 cusr 0.00 csys = 0.21 CPU) Result: NOTESTS ##### Show quoted text

> So the failures can be diagrammed as follows: > > ##### > t/12cpan.t -> fails with YAML::Syck > t/31sessions.t -> fails with YAML > ##### > > Is this diagnosis correct? > > Thank you very much. > Jim Keenan

Thu Jan 30 11:54:20 2020 TINITA [...] cpan.org - Correspondence added

Since I uploaded the new YAML.pm, I would like to help. I tried to add things like ${ "$yaml_module\::LoadBlessed" } = 1; in several places in the modules, and even hardcoded $YAML::LoadBlessed = 1; but the tests are still failing. Since that was the only change in YAML.pm, it must be that change, but the code is apparently too complicated for me to fix, and it's hard to see from the test failures, what's going wrong.

Thu Jan 30 11:59:34 2020 TINITA [...] cpan.org - Cc TINITA added

Thu Jan 30 12:02:20 2020 ppisar [...] redhat.com - Correspondence added

Subject:	Re: [rt.cpan.org #131615] t/31sessions.t fails with YAML-1.30
Date:	Thu, 30 Jan 2020 17:55:42 +0100
To:	James E Keenan via RT <bug-CPAN [...] rt.cpan.org>
From:	Petr Pisar <ppisar [...] redhat.com>

On Thu, Jan 30, 2020 at 11:10:11AM -0500, James E Keenan via RT wrote: Show quoted text

> > I get these failures as well with perl-5.30.1 (actually, perl built at tag > v5.30.1) and YAML-1.30. > > Unlike the failures in t/12cpan.t being discussed in > https://rt.cpan.org/Ticket/Display.html?id=131602, YAML::Syck has no bearing > on these failures. I first installed YAML, built CPAN, and called 'prove' > on t/31sessions.t. Test failures. I then uninstalled YAML, installed > YAML::Syck, built and tested. No test failures. > > So the failures can be diagrammed as follows: > > ##### > t/12cpan.t -> fails with YAML::Syck > t/31sessions.t -> fails with YAML > ##### > > Is this diagnosis correct? >

That's what I observed. I also tried setting $YAML::LoadBlessed at various places, but also was unable to make the test passing. Maybe I do not undestand the tests enough. I suspect that "the historically second" subtest of t/31sessions.t loads YAML files created with the previous "the historically first" subtest. But then I don't understand how "perl -Ilib t/31sessions.t --session='the historically second'" is supposed to work since in that case there shouldn't be any pregenerated YAML file. The tests also seems to ignore changes in ./lib. I had to run "make" to update ./blib. That's maybe because the YAML.pm is actually loaded twice. Once from t/31sessions.t and then from a forked CPAN under the test. -- Petr

Download signature.asc
application/pgp-signature 228b

Message body not shown because it is not plain text.

Thu Jan 30 12:06:57 2020 TINITA [...] cpan.org - Correspondence added

On Thu Jan 30 18:02:20 2020, ppisar wrote: Show quoted text

> YAML file. The tests also seems to ignore changes in ./lib. I had to > run > "make" to update ./blib. That's maybe because the YAML.pm is actually > loaded > twice. Once from t/31sessions.t and then from a forked CPAN under the > test.

That was a good hint! I ran make, and the test is passing now, although I explicitly run prove -l t/31sessions.t and the test itself is actually putting lib in @INC... So, some of my changes fixed it, and I will try to find out which one.

Thu Jan 30 14:06:15 2020 TINITA [...] cpan.org - Correspondence added

https://github.com/andk/cpanpm/pull/133

Fri Jan 31 04:06:12 2020 ppisar [...] redhat.com - Correspondence added

Dne Čt 30.led.2020 14:06:15, TINITA napsal(a): Show quoted text

> > https://github.com/andk/cpanpm/pull/133 >

Thanks. It works for me.

Tue Feb 11 10:43:34 2020 gregoa [...] cpan.org - Cc GREGOA added