Bug #131597 for Data-Serializer: Test suite fails (with YAML 1.30?)

Wed Jan 29 09:15:37 2020 SREZIC [...] cpan.org - Ticket created

CC:	cpan [...] tinita.de
Subject:	Test suite fails (with YAML 1.30?)

The test suite started to fail: ... Can't call method "package_test" on unblessed reference at ./t/serializer-testlib line 426. t/01-06-YAML.t ................ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/16 subtests ... Can't call method "package_test" on unblessed reference at ./t/serializer-testlib line 426. t/02-01-Orig-Raw.t ............ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 90/224 subtests ... (etc) ... It seems that this happens if YAML 1.30 is installed, possibly because of this change: https://metacpan.org/source/TINITA/YAML-1.30/Changes#L2

Wed Jan 29 09:22:37 2020 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

cpan [...] tinita.de

On 2020-01-29 09:15:37, SREZIC wrote: Show quoted text

> The test suite started to fail: > > ... > Can't call method "package_test" on unblessed reference at > ./t/serializer-testlib line 426. > t/01-06-YAML.t ................ > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 2/16 subtests > ... > Can't call method "package_test" on unblessed reference at > ./t/serializer-testlib line 426. > t/02-01-Orig-Raw.t ............ > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 90/224 subtests > ... (etc) ... > > It seems that this happens if YAML 1.30 is installed, possibly because > of this change: https://metacpan.org/source/TINITA/YAML- > 1.30/Changes#L2

YAML::Syck has a similar change, so 01-11-YAML-Syck.t may also fail if the newest YAML::Syck is installed: ... Can't call method "package_test" on unblessed reference at ./t/serializer-testlib line 426. t/01-11-YAML-Syck.t ........... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 8/16 subtests ...

Thu Jan 30 15:07:09 2020 TINITA [...] cpan.org - Correspondence added

I wrote an email to the author, asking if they plan to make a release, or if they would be willing to give the module to someone else.

Thu Jan 30 15:07:09 2020 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 30 17:52:00 2020 TINITA [...] cpan.org - Correspondence added

I attached a patch

Subject:

load-blessed.patch

diff --git a/lib/Data/Serializer/YAML.pm b/lib/Data/Serializer/YAML.pm index 0b17ec3..7e5ee98 100644 --- a/lib/Data/Serializer/YAML.pm +++ b/lib/Data/Serializer/YAML.pm @@ -13,6 +13,7 @@ sub serialize { } sub deserialize { + local $YAML::LoadBlessed = 1; return Load($_[1]); } diff --git a/lib/Data/Serializer/YAML/Syck.pm b/lib/Data/Serializer/YAML/Syck.pm index 13f92df..11cf6d1 100644 --- a/lib/Data/Serializer/YAML/Syck.pm +++ b/lib/Data/Serializer/YAML/Syck.pm @@ -13,6 +13,7 @@ sub serialize { } sub deserialize { + local $YAML::Syck::LoadBlessed = 1; return YAML::Syck::Load($_[1]); }

Thu Jan 30 18:16:01 2020 neil [...] neely.cx - Taken

Thu Jan 30 18:17:43 2020 neil [...] neely.cx - Correspondence added

I've just pushed up version 0.61 that intentionally disables LoadBlessed for both YAML and YAML::Syck, and disables the object tests in the test harness.

Thu Jan 30 18:24:52 2020 TINITA [...] cpan.org - Correspondence added

On Fri Jan 31 00:17:43 2020, NEELY wrote: Show quoted text

> I've just pushed up version 0.61 that intentionally disables > LoadBlessed for both YAML and YAML::Syck, and disables the object > tests in the test harness.

Thanks Neil for the quick response and release!

Fri Jan 31 11:07:38 2020 neil [...] neely.cx - TimeWorked changed from (no value) to '10'

Fri Jan 31 11:07:38 2020 neil [...] neely.cx - Status changed from 'open' to 'resolved'

Fri Jan 31 11:07:39 2020 neil [...] neely.cx - Fixed in 0.61 added