Bug #13158 for CGI: Needs test: empty name/value, when saved, prevents proper restore from filehandle.

Wed Jun 08 19:11:12 2005 Guest - Ticket created

Subject:

empty name/value, when saved, prevents proper restore from filehandle.

The "save to filehandle" and "retrieve from filehandle" functions sometimes don't do a round-trip properly, if there exists in a submitted form page: <input type="radio" name="" value="" checked /> This causes a single line with only an equals on it (the empty string for both name and value). When CGI reads this in, it does a last LOOP on the regex matching /^=/. Either change the last LOOP to a next LOOP or filter out blank named items from the save to filehandle functionality

Mon Apr 20 22:21:58 2009 MARKSTOS [...] cpan.org - Correspondence added

On Wed Jun 08 19:11:12 2005, guest wrote: Show quoted text

> The "save to filehandle" and "retrieve from filehandle" functions > sometimes don't do a round-trip properly, if there exists in a > submitted form page: > > <input type="radio" name="" value="" checked /> > > This causes a single line with only an equals on it (the empty string > for both name and value). When CGI reads this in, it does a last LOOP > on the regex matching /^=/. > > Either change the last LOOP to a next LOOP or filter out blank named > items from the save to filehandle functionality

Thanks for the report. From looking at 3.43, it looks like the issue might still exist, because this line is still there: last if /^=/; Would you be willing to submit an automated test case which illustrates triggering this issue, as well as your proposed fix for it? Mark

Mon Apr 20 22:21:59 2009 The RT System itself - Status changed from 'new' to 'open'

Sun Jul 19 20:05:14 2009 MARKSTOS [...] cpan.org - Taken

Sun Jul 19 20:05:42 2009 MARKSTOS [...] cpan.org - Subject changed from 'empty name/value, when saved, prevents proper restore from filehandle.' to 'Needs test: empty name/value, when saved, prevents proper restore from filehandle.'

Sun Jul 19 20:05:42 2009 MARKSTOS [...] cpan.org - Broken in 3.43 added

Mon Aug 17 07:40:30 2009 rhesa [...] cpan.org - Correspondence added

Given that the documentation of the save() method mentions that it uses a lone '=' as a session separator, I recommend skipping blank param-value pairs in save(). Such a param is of little value anyway, IMHO. Note that the BoulderIO documentation doesn't say anything about unnamed parameters, so I assume that a query string such as "=foo;=bar" should be preserved. This implies that the "last" condition should change to /^=$/. See http://github.com/rhesa/CGI.pm/commit/d22626ab9eb2fb7a82b43ac26cf49fe022d9b147 for the fix (+tests).

Mon Aug 17 07:48:32 2009 MARKSTOS [...] cpan.org - Correspondence added

Thanks, Rhesa. Your patch has now been reviewed and accepted and published to my github repo. Mark

Mon Aug 17 07:48:34 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'patched'

Wed Sep 09 22:06:00 2009 MARKSTOS [...] cpan.org - Correspondence added

Subject:

Thanks, released

The patch for this ticket has now been released in CGI.pm 3.47, and this ticket is considered resolved. Thanks again for you help to improve CGI.pm! Mark

Wed Sep 09 22:06:02 2009 The RT System itself - Status changed from 'patched' to 'open'

Wed Sep 09 22:06:03 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'

Fri May 23 14:28:29 2014 The RT System itself - Queue changed from CGI.pm to CGI

Bug #13158 for CGI: Needs test: empty name/value, when saved, prevents proper restore from filehandle.

Preferred bug tracker