Skip Menu |

This queue is for tickets about the CGI-Lingua CPAN distribution.

Report information
The Basics
Id: 131347
Status: resolved
Priority: 0/
Queue: CGI-Lingua

People
Owner: NHORNE [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.59
Fixed in: (no value)



Subject: t/rt79214.t fails (without diagnostics)
On some of my systems I see the following failure: ... # Ignore messages about Can't determine language from IP 24.50.196.23. See https://rt.cpan.org/Public/Bug/Display.html?id=79214 # Failed test at t/rt79214.t line 33. # Failed test at t/rt79214.t line 35. # Looks like you failed 2 tests of 8. t/rt79214.t ........ Dubious, test returned 2 (wstat 512, 0x200) Failed 2/8 subtests ... Unfortunately there's no further diagnostics here --- maybe it would be better if the test script used is($l->country(),'pr'); instead of ok($l->country() eq 'pr');
Thank you for your bug report. Using Github actions I have been able to reproduce the problem and I will look into it.
Thank you for your bug report. Using Github actions I have been able to reproduce the problem and I will look into it.
It looks like RT#79214 has been fixed, hence the change in behaviour. I'm going to update the minimum required version of Locale::Object and also change the test as you suggested - thanks.
My last comment was wrong. In fact the test fails on machines without JSON::Parse. I'm investigating further.
Potential fix uploaded to GitHub https://github.com/nigelhorne/CGI-Lingua Please test.
Stalling for reporter to test.
On 2020-01-05 12:38:51, NHORNE wrote: Show quoted text
> Stalling for reporter to test.
I tried commit 1923464d908925adeff518fcac62ef7be38e57fe and the problematic test script passes now.
Fixed in 0.60, but RT hasn't caught up yet so I can't choose that from the 'Fixed in' pull-down list.