Bug #131339 for Data-ICal: GEO param escaped when should not be

Thu Jan 02 11:09:20 2020 LANCEW [...] cpan.org - Ticket created

CC:	lw [...] judocoach.com
Subject:	GEO param escaped when should not be

the semi-colon in Geo value is being escaped and I don't believe it should be: The following code: use strict; use warnings; use Data::ICal; my $cal = Data::ICal->new; $cal->add_property( geo => '123.000;-0.001' ); print $cal->as_string; will produce: BEGIN:VCALENDAR VERSION:2.0 GEO:123.000\;-0.001 PRODID:Data::ICal 0.22 END:VCALENDAR Note that the Geo param is "GEO:123.000\;-0.001" when I believe it should be "GEO:123.000;-0.001" Changing Data::ICal::Property's _value_as_string sub "should" work. I.e. $value =~ s/;/\\;/gs unless lc($key) eq 'rrule' || lc($key) eq 'geo'; Opinions? I was not able to identify a git/svn repo for the module; happy to provide a PR if there is one available. Lance

Thu Jan 02 11:33:28 2020 LANCEW [...] cpan.org - Correspondence added

Looks like I may have found your repo: https://github.com/bestpractical/data-ical Shall fork and experiment there. :-)

Thu Jan 02 11:51:26 2020 LANCEW [...] cpan.org - Correspondence added

Have made an initial PR: https://github.com/bestpractical/data-ical/pull/2

Fri Jan 03 10:03:47 2020 LANCEW [...] cpan.org - Correspondence added

On Thu Jan 02 11:09:20 2020, LANCEW wrote: Show quoted text

> the semi-colon in Geo value is being escaped and I don't believe it > should be: > > The following code: > > use strict; > use warnings; > > use Data::ICal; > > my $cal = Data::ICal->new; > > $cal->add_property( > geo => '123.000;-0.001' > ); > > > print $cal->as_string; > > > > will produce: > > BEGIN:VCALENDAR > VERSION:2.0 > GEO:123.000\;-0.001 > PRODID:Data::ICal 0.22 > END:VCALENDAR > > > Note that the Geo param is "GEO:123.000\;-0.001" when I believe it > should be "GEO:123.000;-0.001" > > > Changing Data::ICal::Property's _value_as_string sub "should" work. > I.e. > > $value =~ s/;/\\;/gs unless lc($key) eq 'rrule' || lc($key) eq 'geo'; > > Opinions? > > > I was not able to identify a git/svn repo for the module; happy to > provide a PR if there is one available. > > Lance

Fri Jan 03 10:03:48 2020 LANCEW [...] cpan.org - Status changed from 'new' to 'patched'