Bug #131332 for Data-Sah-Coerce: *date* tests fail (with older Time::Local?)

Thu Jan 02 04:12:34 2020 SREZIC [...] cpan.org - Ticket created

Subject:

*date* tests fail (with older Time::Local?)

On some of my smokers the three *date* tests fail: ... # Failed test at t/perl-To_date.t line 33. # got: undef # expected: '1451606400' # Failed test at t/perl-To_date.t line 34. # got: undef # expected: '1451606400' # Failed test at t/perl-To_date.t line 37. # got: undef # expected: '-63158400' # Looks like you failed 3 tests of 3. # Failed test 'from iso8601 string' # at t/perl-To_date.t line 38. # Looks like you failed 1 test of 5. # Failed test 'coerce_to=float(epoch)' # at t/perl-To_date.t line 39. # Looks like you failed 1 test of 3. t/perl-To_date.t ......... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests (less 1 skipped subtest: 1 okay) # Failed test at t/perl-To_datenotime.t line 19. # undef # doesn't match '(?^:\A\d+\z)' # Failed test at t/perl-To_datenotime.t line 21. # undef # doesn't match '(?^:\A-\d+\z)' # Looks like you failed 2 tests of 3. # Failed test 'from iso8601 string' # at t/perl-To_datenotime.t line 22. # Looks like you failed 1 test of 1. # Failed test 'coerce_to=float(epoch)' # at t/perl-To_datenotime.t line 23. # Looks like you failed 1 test of 3. t/perl-To_datenotime.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests (less 1 skipped subtest: 1 okay) # Failed test at t/perl-To_datetime.t line 18. # undef # doesn't match '(?^:\A\d+\z)' # Failed test at t/perl-To_datetime.t line 21. # got: undef # expected: '-63158400' # Looks like you failed 2 tests of 3. # Failed test 'from iso8601 string' # at t/perl-To_datetime.t line 22. # Looks like you failed 1 test of 1. # Failed test 'coerce_to=float(epoch)' # at t/perl-To_datetime.t line 23. # Looks like you failed 1 test of 3. t/perl-To_datetime.t ..... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests (less 1 skipped subtest: 1 okay) ... Possible reason: Time::Local is too old on these systems (maybe a version without timelocal/gm_modern?).

Thu Jan 02 06:48:48 2020 PERLANCAR [...] cpan.org - Correspondence added

Fixed by requiring Time::Local 1.27 in 0.044. Thanks. On Thu, 2 Jan 2020 09:12:34 GMT, SREZIC wrote: Show quoted text

> On some of my smokers the three *date* tests fail: > > ... > # Failed test at t/perl-To_date.t line 33. > # got: undef > # expected: '1451606400' > > # Failed test at t/perl-To_date.t line 34. > # got: undef > # expected: '1451606400' > > # Failed test at t/perl-To_date.t line 37. > # got: undef > # expected: '-63158400' > # Looks like you failed 3 tests of 3. > > # Failed test 'from iso8601 string' > # at t/perl-To_date.t line 38. > # Looks like you failed 1 test of 5. > > # Failed test 'coerce_to=float(epoch)' > # at t/perl-To_date.t line 39. > # Looks like you failed 1 test of 3. > t/perl-To_date.t ......... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/3 subtests > (less 1 skipped subtest: 1 okay) > > # Failed test at t/perl-To_datenotime.t line 19. > # undef > # doesn't match '(?^:\A\d+\z)' > > # Failed test at t/perl-To_datenotime.t line 21. > # undef > # doesn't match '(?^:\A-\d+\z)' > # Looks like you failed 2 tests of 3. > > # Failed test 'from iso8601 string' > # at t/perl-To_datenotime.t line 22. > # Looks like you failed 1 test of 1. > > # Failed test 'coerce_to=float(epoch)' > # at t/perl-To_datenotime.t line 23. > # Looks like you failed 1 test of 3. > t/perl-To_datenotime.t ... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/3 subtests > (less 1 skipped subtest: 1 okay) > > # Failed test at t/perl-To_datetime.t line 18. > # undef > # doesn't match '(?^:\A\d+\z)' > > # Failed test at t/perl-To_datetime.t line 21. > # got: undef > # expected: '-63158400' > # Looks like you failed 2 tests of 3. > > # Failed test 'from iso8601 string' > # at t/perl-To_datetime.t line 22. > # Looks like you failed 1 test of 1. > > # Failed test 'coerce_to=float(epoch)' > # at t/perl-To_datetime.t line 23. > # Looks like you failed 1 test of 3. > t/perl-To_datetime.t ..... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/3 subtests > (less 1 skipped subtest: 1 okay) > ... > > > Possible reason: Time::Local is too old on these systems (maybe a > version without timelocal/gm_modern?).

Thu Jan 02 06:48:49 2020 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 02 06:48:49 2020 PERLANCAR [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Jan 02 10:06:54 2020 SREZIC [...] cpan.org - Correspondence added

On 2020-01-02 06:48:48, PERLANCAR wrote: Show quoted text

> Fixed by requiring Time::Local 1.27 in 0.044. Thanks. > > On Thu, 2 Jan 2020 09:12:34 GMT, SREZIC wrote:

> > On some of my smokers the three *date* tests fail: > > > > ... > > # Failed test at t/perl-To_date.t line 33. > > # got: undef > > # expected: '1451606400' > > > > # Failed test at t/perl-To_date.t line 34. > > # got: undef > > # expected: '1451606400' > > > > # Failed test at t/perl-To_date.t line 37. > > # got: undef > > # expected: '-63158400' > > # Looks like you failed 3 tests of 3. > > > > # Failed test 'from iso8601 string' > > # at t/perl-To_date.t line 38. > > # Looks like you failed 1 test of 5. > > > > # Failed test 'coerce_to=float(epoch)' > > # at t/perl-To_date.t line 39. > > # Looks like you failed 1 test of 3. > > t/perl-To_date.t ......... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/3 subtests > > (less 1 skipped subtest: 1 okay) > > > > # Failed test at t/perl-To_datenotime.t line 19. > > # undef > > # doesn't match '(?^:\A\d+\z)' > > > > # Failed test at t/perl-To_datenotime.t line 21. > > # undef > > # doesn't match '(?^:\A-\d+\z)' > > # Looks like you failed 2 tests of 3. > > > > # Failed test 'from iso8601 string' > > # at t/perl-To_datenotime.t line 22. > > # Looks like you failed 1 test of 1. > > > > # Failed test 'coerce_to=float(epoch)' > > # at t/perl-To_datenotime.t line 23. > > # Looks like you failed 1 test of 3. > > t/perl-To_datenotime.t ... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/3 subtests > > (less 1 skipped subtest: 1 okay) > > > > # Failed test at t/perl-To_datetime.t line 18. > > # undef > > # doesn't match '(?^:\A\d+\z)' > > > > # Failed test at t/perl-To_datetime.t line 21. > > # got: undef > > # expected: '-63158400' > > # Looks like you failed 2 tests of 3. > > > > # Failed test 'from iso8601 string' > > # at t/perl-To_datetime.t line 22. > > # Looks like you failed 1 test of 1. > > > > # Failed test 'coerce_to=float(epoch)' > > # at t/perl-To_datetime.t line 23. > > # Looks like you failed 1 test of 3. > > t/perl-To_datetime.t ..... > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/3 subtests > > (less 1 skipped subtest: 1 okay) > > ... > > > > > > Possible reason: Time::Local is too old on these systems (maybe a > > version without timelocal/gm_modern?).

> >

Reopening --- I still see test failures. Maybe it shouldn't be specified just a TestRecommended, or alternatively the tests should be skipped if Time::Local is too old?

Thu Jan 02 10:06:55 2020 SREZIC [...] cpan.org - Status changed from 'resolved' to 'open'

Thu Jan 02 10:07:34 2020 SREZIC [...] cpan.org - Broken in 0.043 added

Thu Jan 02 10:07:34 2020 SREZIC [...] cpan.org - Broken in 0.044 added

Thu Jan 02 10:07:34 2020 SREZIC [...] cpan.org - Broken in 0.040 deleted

Thu Jan 02 18:59:37 2020 PERLANCAR [...] cpan.org - Correspondence added

On Thu, 2 Jan 2020 15:06:54 GMT, SREZIC wrote: Show quoted text

> Reopening --- I still see test failures. Maybe it shouldn't be > specified just a TestRecommended, or alternatively the tests should be > skipped if Time::Local is too old?

Ah sorry about that. Moved to RuntimeRequires. Tests should not be skipped, it's quite essential functionality. Fixed in 0.046.

Thu Jan 02 18:59:53 2020 PERLANCAR [...] cpan.org - Status changed from 'open' to 'resolved'