On 2020-01-27 21:26:38, PEVANS wrote:
Show quoted text> On Mon Dec 30 06:01:13 2019, SREZIC wrote:
> > Some tests fail on some smokers, probably if the TERM environment
> > variable is not set (smoker is started through a crontab --- usually
> > an environment without a TERM):
>
> Hrm; I don't think it's that:
>
> leo@shy:~/src/libtickit [bzr]
> $ TERM= make test
> ...
> All tests successful.
>
> Is it only those four tests that fail? Most odd if so, because those
> four all do
>
> tt = tickit_term_new_for_termtype("xterm");
>
> which would suggest something odd with the `xterm` terminfo on your
> machine, but many other tests also do that which you haven't listed as
> failing.
Just setting TERM to the empty string is not enough --- it has to be completely unset:
$ perl5.31.8 src/t/11term-output-xterm.t
ok 1 - tickit_term_new_for_termtype
ok 2 - tickit_term_get_termtype
ok 3 - tickit_term_get_output_fd
ok 4 - get_size lines
ok 5 - get_size cols
ok 6 - buffer after tickit_term_print
ok 7 - buffer after tickit_term_goto line+col
ok 8 - buffer after tickit_term_goto line+col0
ok 9 - buffer after tickit_term_goto line
ok 10 - buffer after tickit_term_goto col
ok 11 - buffer after tickit_term_goto col0
ok 12 - buffer after tickit_term_move down 1
ok 13 - buffer after tickit_term_move down 2
ok 14 - buffer after tickit_term_move down 1
ok 15 - buffer after tickit_term_move down 2
ok 16 - buffer after tickit_term_move right 1
ok 17 - buffer after tickit_term_move right 2
ok 18 - buffer after tickit_term_move left 1
ok 19 - buffer after tickit_term_move left 2
ok 20 - buffer after tickit_term_scrollrect lines 3-9 1 down
ok 21 - buffer after tickit_term_scrollrect lines 3-17 8 down
ok 22 - buffer after tickit_term_scrollrect lines 3-9 1 up
ok 23 - buffer after tickit_term_scrollrect lines 3-17 8 up
ok 24 - buffer after tickit_term_scrollrect line 5 3 right
ok 25 - buffer after tickit_term_scrollrect lines 6-7 cols 10-80 5 right
ok 26 - buffer after tickit_term_scrollrect line 5 3 left
ok 27 - buffer after tickit_term_scrollrect lines 6-7 cols 10-80 5 left
ok 28 - tickit_term cannot scroll partial lines vertically
ok 29 - tickit_term cannot scroll partial lines horizontally
ok 30 - tickit_term can scroll partial lines vertically with DECSLRM enabled
ok 31 - buffer after tickit_term_scroll lines 3-7 cols 10-69 down
ok 32 - tickit_term can scroll partial lines horizontally with DECSLRM enabled
ok 33 - buffer after tickit_term_scroll lines 3-7 cols 10-69 right
ok 34 - tickit_term can scroll partial lines horizontally with DECSLRM enabled
ok 35 - buffer after tickit_term_scroll line 3 cols 10-69 right
ok 36 - buffer after tickit_term_clear
ok 37 - buffer after tickit_term_erasech 1 nomove
ok 38 - buffer after tickit_term_erasech 3 nomove
ok 39 - buffer after tickit_term_erasech 1 move
ok 40 - buffer after tickit_term_erasech 3 move
ok 41 - tickit_term_unref
1..41
TERM= perl5.31.8 src/t/11term-output-xterm.t
ok 1 - tickit_term_new_for_termtype
ok 2 - tickit_term_get_termtype
ok 3 - tickit_term_get_output_fd
ok 4 - get_size lines
ok 5 - get_size cols
ok 6 - buffer after tickit_term_print
ok 7 - buffer after tickit_term_goto line+col
ok 8 - buffer after tickit_term_goto line+col0
ok 9 - buffer after tickit_term_goto line
ok 10 - buffer after tickit_term_goto col
ok 11 - buffer after tickit_term_goto col0
ok 12 - buffer after tickit_term_move down 1
ok 13 - buffer after tickit_term_move down 2
ok 14 - buffer after tickit_term_move down 1
ok 15 - buffer after tickit_term_move down 2
ok 16 - buffer after tickit_term_move right 1
ok 17 - buffer after tickit_term_move right 2
ok 18 - buffer after tickit_term_move left 1
ok 19 - buffer after tickit_term_move left 2
ok 20 - buffer after tickit_term_scrollrect lines 3-9 1 down
ok 21 - buffer after tickit_term_scrollrect lines 3-17 8 down
ok 22 - buffer after tickit_term_scrollrect lines 3-9 1 up
ok 23 - buffer after tickit_term_scrollrect lines 3-17 8 up
ok 24 - buffer after tickit_term_scrollrect line 5 3 right
ok 25 - buffer after tickit_term_scrollrect lines 6-7 cols 10-80 5 right
ok 26 - buffer after tickit_term_scrollrect line 5 3 left
ok 27 - buffer after tickit_term_scrollrect lines 6-7 cols 10-80 5 left
ok 28 - tickit_term cannot scroll partial lines vertically
ok 29 - tickit_term cannot scroll partial lines horizontally
ok 30 - tickit_term can scroll partial lines vertically with DECSLRM enabled
ok 31 - buffer after tickit_term_scroll lines 3-7 cols 10-69 down
ok 32 - tickit_term can scroll partial lines horizontally with DECSLRM enabled
ok 33 - buffer after tickit_term_scroll lines 3-7 cols 10-69 right
ok 34 - tickit_term can scroll partial lines horizontally with DECSLRM enabled
ok 35 - buffer after tickit_term_scroll line 3 cols 10-69 right
ok 36 - buffer after tickit_term_clear
ok 37 - buffer after tickit_term_erasech 1 nomove
ok 38 - buffer after tickit_term_erasech 3 nomove
ok 39 - buffer after tickit_term_erasech 1 move
ok 40 - buffer after tickit_term_erasech 3 move
ok 41 - tickit_term_unref
1..41
But:
(unset TERM; perl5.31.8 src/t/11term-output-xterm.t )
ok 1 - tickit_term_new_for_termtype
ok 2 - tickit_term_get_termtype
ok 3 - tickit_term_get_output_fd
ok 4 - get_size lines
ok 5 - get_size cols
ok 6 - buffer after tickit_term_print
ok 7 - buffer after tickit_term_goto line+col
ok 8 - buffer after tickit_term_goto line+col0
ok 9 - buffer after tickit_term_goto line
ok 10 - buffer after tickit_term_goto col
ok 11 - buffer after tickit_term_goto col0
ok 12 - buffer after tickit_term_move down 1
ok 13 - buffer after tickit_term_move down 2
ok 14 - buffer after tickit_term_move down 1
ok 15 - buffer after tickit_term_move down 2
ok 16 - buffer after tickit_term_move right 1
ok 17 - buffer after tickit_term_move right 2
ok 18 - buffer after tickit_term_move left 1
ok 19 - buffer after tickit_term_move left 2
ok 20 - buffer after tickit_term_scrollrect lines 3-9 1 down
ok 21 - buffer after tickit_term_scrollrect lines 3-17 8 down
ok 22 - buffer after tickit_term_scrollrect lines 3-9 1 up
ok 23 - buffer after tickit_term_scrollrect lines 3-17 8 up
ok 24 - buffer after tickit_term_scrollrect line 5 3 right
ok 25 - buffer after tickit_term_scrollrect lines 6-7 cols 10-80 5 right
ok 26 - buffer after tickit_term_scrollrect line 5 3 left
ok 27 - buffer after tickit_term_scrollrect lines 6-7 cols 10-80 5 left
ok 28 - tickit_term cannot scroll partial lines vertically
ok 29 - tickit_term cannot scroll partial lines horizontally
Assertion failed: (term != NULL), function unibi_from_term, file uniutil.c, line 183.
[1] 53550 abort ( unset TERM; perl5.31.8 src/t/11term-output-xterm.t; )