Bug #131291 for MojoX-Renderer-Xslate: __DIE__ signal handler captures error wrapped by eval

Sun Dec 29 13:34:45 2019 thomas [...] careerjet.com - Ticket created

Subject:

__DIE__ signal handler captures error wrapped by eval

I noticed that the __DIE__ signal handler captures any error even if it is wrapped by an eval statement. That means exceptions cannot be handled properly. I found a way out which is to replace the __DIE__ signal handler by the following: local $SIG{__DIE__} = sub { my ($package, $filename, $line, $subroutine) = caller(1); if (!$subroutine || $subroutine ne '(eval)') { $xslate_err = shift; } };

Sun Dec 29 20:09:06 2019 ether [...] cpan.org - Correspondence added

On 2019-12-29 10:34:45, TBUSCH wrote: Show quoted text

> I noticed that the __DIE__ signal handler captures any error even if > it is wrapped by an eval statement. That means exceptions cannot be > handled properly. > > I found a way out which is to replace the __DIE__ signal handler by > the following: > > local $SIG{__DIE__} = sub { > my ($package, $filename, $line, $subroutine) = caller(1); > if (!$subroutine || $subroutine ne '(eval)') { > $xslate_err = shift; > } > };

Better is to check the value of $^S, which all __DIE__ handlers ought to do.

Sun Dec 29 20:09:06 2019 The RT System itself - Status changed from 'new' to 'open'

Mon Dec 30 07:04:47 2019 thomas [...] careerjet.com - Correspondence added

Show quoted text

> Better is to check the value of $^S, which all __DIE__ handlers ought to do.

Nice!! Thanks for your help. So the __DIE__ signal handler should be: local $SIG{__DIE__} = sub { if (!$^S) { $xslate_err = shift; } };

Fri Jan 03 13:27:22 2020 HJANSEN [...] cpan.org - Correspondence added

Sorry for being dull-witted, but I'm having trouble to understand what you're trying to achieve. Given that the handler is currently created directly inside an "eval" (https://github.com/gray/mojox-renderer-xslate/blob/master/lib/MojoX/Renderer/Xslate.pm#L64), I wonder if $^S wouldn't *always* be true, anyway? I certainly would've liked to test this if only I understood just what your code would look like: could you post some code fragment to illustrate?