Bug #131227 for Firefox-Marionette: slight bug about return code?

Mon Dec 23 19:45:04 2019 bokutin [...] cpan.org - Ticket created

Subject:

slight bug about return code?

% perl -E 'use Firefox::Marionette; my $ff = Firefox::Marionette->new; exit 0'; echo $? 255 % perl -E 'use Firefox::Marionette; my $ff = Firefox::Marionette->new; undef $ff; exit 0'; echo $? 0 You can fix it below, but I don't know if it is suitable. --- lib/Firefox/Marionette.pm.orig 2019-12-24 09:41:47.428022000 +0900 +++ lib/Firefox/Marionette.pm 2019-12-24 09:41:48.467972000 +0900 @@ -4731,6 +4731,7 @@ sub DESTROY { my ($self) = @_; + local $CHILD_ERROR; if ( $self->{survive} ) { } elsif ( $self->{creation_pid} == $PROCESS_ID ) {

Tue Dec 24 04:37:39 2019 DDICK [...] cpan.org - Correspondence added

On Tue Dec 24 11:45:04 2019, bokutin wrote: Show quoted text

> % perl -E 'use Firefox::Marionette; my $ff = Firefox::Marionette->new; > exit 0'; echo $? > 255 > % perl -E 'use Firefox::Marionette; my $ff = Firefox::Marionette->new; > undef $ff; exit 0'; echo $? > 0 > > You can fix it below, but I don't know if it is suitable. > > --- lib/Firefox/Marionette.pm.orig 2019-12-24 09:41:47.428022000 > +0900 > +++ lib/Firefox/Marionette.pm 2019-12-24 09:41:48.467972000 +0900 > @@ -4731,6 +4731,7 @@ > > sub DESTROY { > my ($self) = @_; > + local $CHILD_ERROR; > if ( $self->{survive} ) { > } > elsif ( $self->{creation_pid} == $PROCESS_ID ) {

Thanks for the patch. Uploaded in 0.88.

Tue Dec 24 04:37:40 2019 The RT System itself - Status changed from 'new' to 'open'

Tue Dec 24 04:37:40 2019 DDICK [...] cpan.org - Status changed from 'open' to 'patched'

Tue Dec 24 15:14:58 2019 bokutin [...] cpan.org - Correspondence added

Thank you very much!

Tue Dec 24 15:14:59 2019 bokutin [...] cpan.org - Status changed from 'patched' to 'resolved'