Subject: | suggest file handle and file descriptor interfaces |
Date: | Thu, 07 Nov 2019 09:59:48 +1100 |
To: | bug-Sys-PageCache [...] rt.cpan.org |
From: | Kevin Ryde <user42_kevin [...] yahoo.com.au> |
As an idea for a feature, it could be good to have an fadvise variant
taking a file handle or file descriptor. A handle is good to be sure of
advising about the intended thing in case of any file renaming.
I'd suggest different function names, maybe fadvise_fh() and
fadvise_fd(). The latter might be nearly your existing xs func.
I know some modules like to take file name and file handle in one
function by testing for ref-ness, but it's usually bad to enquire into
the nature of an arg since that can go wrong on overloads such as
Path::Class or a number class. (The supposed convenience of a single
func becomes the inconvenience of not transparent to overloads ...)