| Subject: | Totalmem is badly computed on OpenBSD |
| Date: | Fri, 18 Oct 2019 22:47:23 +0200 |
| To: | bug-Sys-MemInfo [...] rt.cpan.org |
| From: | Charlène Wendling <cwen [...] openbsd.org> |
Hi,
This is what tests return on OpenBSD on a machine having 16 gigs of RAM:
===> Regression tests for p5-Sys-MemInfo-0.99
[...]
# Failed test 'Free (7439380480) <= Total (4212338688)'
# at t/1.t line 28.
[...]
To get it work properly on OpenBSD, it's needed to use the same code
used for NetBSD. I'm proposing here a diff that does that.
Charlène.
--8<--
Index: Makefile.PL
--- Makefile.PL.orig
+++ Makefile.PL
@@ -38,9 +38,9 @@ for ($^O) {
}
} elsif (/bsd/) {
copy ('arch/bsd.xs', 'MemInfo.xs');
- if (/netbsd/) {
+ if (/netbsd/ or /openbsd/) {
$define = '-DNETBSD';
- print "Sys::MemInfo for NetBSD\n";
+ print "Sys::MemInfo for NetBSD and OpenBSD\n";
} else {
print "Sys::MemInfo for *BSD\n";
}
-->8--