Skip Menu |

This queue is for tickets about the Mail-DKIM CPAN distribution.

Report information
The Basics
Id: 130713
Status: resolved
Priority: 0/
Queue: Mail-DKIM

People
Owner: mbradshaw [...] cpan.org
Requestors: trichmond [...] proofpoint.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Lowercase domain check
Date: Tue, 15 Oct 2019 17:51:54 +0000
To: "bug-Mail-DKIM [...] rt.cpan.org" <bug-Mail-DKIM [...] rt.cpan.org>
From: Todd Richmond <trichmond [...] proofpoint.com>
Domain check in DomainKey.pm should lowercase the check to prevent an incorrect failure case. Found with real-world msg examples --- lib/Mail/DKIM/PublicKey.pm.orig 2019-03-14 18:26:29.371100459 -0700 +++ lib/Mail/DKIM/PublicKey.pm 2019-03-27 18:56:16.188904438 -0700 @@ -268,7 +268,7 @@ # check subdomains if ( $self->subdomain_flag ) { - unless ( $domain_part eq lc( $self->{'Domain'} ) ) { + unless ( lc( $domain_part ) eq lc( $self->{'Domain'} ) ) { $@ = "does not support signing subdomains\n"; return; }
Thanks, will include in next release.