Bug #130712 for Mail-DKIM: Add spaces around : in Signer.pm

Tue Oct 15 14:06:24 2019 trichmond [...] proofpoint.com - Ticket created

Subject:	Add spaces around : in Signer.pm
Date:	Tue, 15 Oct 2019 18:06:12 +0000
To:	"bug-Mail-DKIM [...] rt.cpan.org" <bug-Mail-DKIM [...] rt.cpan.org>
From:	Todd Richmond <trichmond [...] proofpoint.com>

There should be a space after the : as well as before in Signer.pm --- lib/Mail/DKIM/Signer.pm.orig 2019-03-14 18:26:29.374100474 -0700 +++ lib/Mail/DKIM/Signer.pm 2019-03-15 16:23:52.534132628 -0700 @@ -585,7 +585,7 @@ my $a = $_; scalar grep { lc($a) eq lc($_) } @wanted_headers } @found_headers; - return join( ':', @headers ); + return join(" : ", @headers); } # return nonzero if this is header we should sign

Wed Oct 16 23:35:20 2019 mbradshaw [...] cpan.org - Correspondence added

I don't believe this is the case, can you elaborate on the reasons for this please.

Wed Oct 16 23:35:20 2019 The RT System itself - Status changed from 'new' to 'open'

Wed Oct 16 23:35:20 2019 mbradshaw [...] cpan.org - Taken

Thu Oct 17 12:19:58 2019 trichmond [...] proofpoint.com - Correspondence added

Subject:	Re: [rt.cpan.org #130712] Add spaces around : in Signer.pm
Date:	Thu, 17 Oct 2019 16:19:43 +0000
To:	"bug-Mail-DKIM [...] rt.cpan.org" <bug-Mail-DKIM [...] rt.cpan.org>
From:	Todd Richmond <trichmond [...] proofpoint.com>

I tracked down the original reason we changed this and found there was a better workaround for the issue developed later. The original reason was to better allow line breaks in long headers Please close this issue as wontfix On 10/16/19, 8:35 PM, "Marc Bradshaw via RT" <bug-Mail-DKIM@rt.cpan.org> wrote: <URL: https://urldefense.com/v3/__https://rt.cpan.org/Ticket/Display.html?id=130712__;!YggOdHcy3_sa5w!4rcn0W58KsfovLGU8VCiluom0q0uX_0i5_XwbxK2-VK4309nbKkKSCUW_5AbcvZq0Fk$ > I don't believe this is the case, can you elaborate on the reasons for this please.

Thu Oct 17 21:02:35 2019 mbradshaw [...] cpan.org - Status changed from 'open' to 'rejected'