| Subject: | t/party.t: skip implemented in a wrong way? |
On some of my smokers t/party.t fails like this:
...
# party.t skipped: Can't run without Digest::HMAC_SHA1
t/party.t ................... skipped: (no reason given)
...
Test Summary Report
-------------------
t/party.t (Wstat: 65280 Tests: 0 Failed: 0)
Non-zero exit status: 255
...
http://matrix.cpantesters.org/?dist=Crypt-IDA+0.03 shows also a lot of fail reports.
I think the problem is that the skip is not properly implemented. Instead of just doing a diag() followed by a done_testing() and exit() it should probably be a plan skip_all => ... followed by the exit() call. So probably it's better to write it as (untested):
if ($@) {
plan skip_all => "party.t skipped: Can't run without Digest::HMAC_SHA1 ($@)";
exit;
}