Bug #130471 for Net-SIP: Bug in Leg.pm, found workaround

Mon Sep 09 02:45:19 2019 cj.fooser [...] gmail.com - Ticket created

Subject:	Bug in Leg.pm, found workaround
Date:	Mon, 9 Sep 2019 09:45:01 +0300
To:	bug-Net-SIP [...] rt.cpan.org
From:	cjayho <cj.fooser [...] gmail.com>

Hello. Found a bug in Net::Sip::Simple when using such script (see attachment), got an error when calling ./call.pl <number> <filename>: Expected 'PeerService' at /usr/share/perl5/Net/SIP/Util.pm line 40. So I found myself a workaround to fix that error: in /usr/share/perl5/Net/SIP/Leg.pm line 150 replace from this: last if $sock = INETSOCK(%sockargs, LocalPort => $port); to this last if $sock = INETSOCK(%sockargs, LocalPort => $port, PeerService => $port); Please include this fix in the future release. Thank you.

Message body is not shown because sender requested not to inline it.

Mon Sep 09 07:22:33 2019 Steffen_Ullrich [...] genua.de - Correspondence added

Hi, Unfortunately the fix you propose is wrong since it simply sets the destination port to the source port in all cases, even overriding any destination port which was explicitly given. Please try instead this patch and let me know if this helps: diff --git a/lib/Net/SIP/Leg.pm b/lib/Net/SIP/Leg.pm index c5ec755..0fab7d5 100644 --- a/lib/Net/SIP/Leg.pm +++ b/lib/Net/SIP/Leg.pm @@ -96,7 +96,7 @@ sub new { $dst = lock_ref_keys({ host => $ip, addr => $ip, - port => $port, + port => $port || $default_port, family => $family, }); }

Mon Sep 09 07:22:33 2019 The RT System itself - Status changed from 'new' to 'open'

Mon Sep 09 07:32:40 2019 cj.fooser [...] gmail.com - Correspondence added

On Mon Sep 09 07:22:33 2019, SULLR wrote: Show quoted text

> Hi, > > Unfortunately the fix you propose is wrong since it simply sets the > destination port to the source port in all cases, even overriding any > destination port which was explicitly given. > Please try instead this patch and let me know if this helps: > > diff --git a/lib/Net/SIP/Leg.pm b/lib/Net/SIP/Leg.pm > index c5ec755..0fab7d5 100644 > --- a/lib/Net/SIP/Leg.pm > +++ b/lib/Net/SIP/Leg.pm > @@ -96,7 +96,7 @@ sub new { > $dst = lock_ref_keys({ > host => $ip, > addr => $ip, > - port => $port, > + port => $port || $default_port, > family => $family, > }); > }

got same error: Expected 'PeerService' at /usr/share/perl5/Net/SIP/Util.pm line 40.

Mon Sep 09 07:58:43 2019 Steffen_Ullrich [...] genua.de - Correspondence added

Show quoted text

> got same error: > > Expected 'PeerService' at /usr/share/perl5/Net/SIP/Util.pm line 40.

Next try. This works for me: diff --git a/lib/Net/SIP/Leg.pm b/lib/Net/SIP/Leg.pm index c5ec755..72cf712 100644 --- a/lib/Net/SIP/Leg.pm +++ b/lib/Net/SIP/Leg.pm @@ -138,7 +138,7 @@ sub new { } elsif ($dst) { # with UDP we can create a connected socket if dst is given $sockargs{PeerAddr} = $dst->{addr}; - $sockargs{PeerPort} = $dst->{port}; + $sockargs{PeerPort} = $dst->{port} ||= $default_port; $sockpeer = $dst; }

Mon Sep 09 08:02:15 2019 cj.fooser [...] gmail.com - Correspondence added

On Mon Sep 09 07:58:43 2019, SULLR wrote: Show quoted text

>

> > got same error: > > > > Expected 'PeerService' at /usr/share/perl5/Net/SIP/Util.pm line 40.

> > Next try. This works for me: > > diff --git a/lib/Net/SIP/Leg.pm b/lib/Net/SIP/Leg.pm > index c5ec755..72cf712 100644 > --- a/lib/Net/SIP/Leg.pm > +++ b/lib/Net/SIP/Leg.pm > @@ -138,7 +138,7 @@ sub new { > } elsif ($dst) { > # with UDP we can create a connected socket if dst is given > $sockargs{PeerAddr} = $dst->{addr}; > - $sockargs{PeerPort} = $dst->{port}; > + $sockargs{PeerPort} = $dst->{port} ||= $default_port; > $sockpeer = $dst; > } >

This works for me too. Thank you :)

Mon Sep 09 08:14:48 2019 Steffen_Ullrich [...] genua.de - Correspondence added

Thanks for testing. This is now fixed in https://github.com/noxxi/p5-net-sip/commit/40c8cdb2c096142e50108a1d03ab3f6850a8df7f

Mon Sep 09 08:14:48 2019 Steffen_Ullrich [...] genua.de - Status changed from 'open' to 'resolved'